[rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) - #161148
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
A-rustdoc-js
Urgau
approved these changes
Aug 16, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 16, 2026
Rollup of 12 pull requests Successful merges: - #160529 (Upgrade and deduplicate dependencies) - #161017 (Library: enforce clippy deref lints in CI) - #156674 (bootstrap: add bootstrap step to run stdarch-gen checks in CI) - #161006 ([CI] Build newer `binutils` before building `gcc`) - #161141 (Add documentation for BPF targets) - #161157 (bootstrap: Move several items out of the crate root) - #161053 (Add regression test for borrow of array drop type in const) - #161073 (Add regression test for path printing with infinitely many visible names) - #161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation) - #161146 (Switch to c8a EC2 runner for auto merges) - #161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore)) - #161150 (add crashtests [4/N])
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 16, 2026
…uwer Rollup of 12 pull requests Successful merges: - #160529 (Upgrade and deduplicate dependencies) - #161017 (Library: enforce clippy deref lints in CI) - #156674 (bootstrap: add bootstrap step to run stdarch-gen checks in CI) - #161006 ([CI] Build newer `binutils` before building `gcc`) - #161141 (Add documentation for BPF targets) - #161157 (bootstrap: Move several items out of the crate root) - #161053 (Add regression test for borrow of array drop type in const) - #161073 (Add regression test for path printing with infinitely many visible names) - #161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation) - #161103 (cleanup: rip out unnecessary `iter().last()` and `iter().next()`) - #161146 (Switch to c8a EC2 runner for auto merges) - #161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore))
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 16, 2026
…uwer Rollup of 17 pull requests Successful merges: - #160529 (Upgrade and deduplicate dependencies) - #161017 (Library: enforce clippy deref lints in CI) - #160416 (std: fix unix socket address truncation without a trailing NUL) - #161006 ([CI] Build newer `binutils` before building `gcc`) - #161141 (Add documentation for BPF targets) - #161157 (bootstrap: Move several items out of the crate root) - #161185 (std: guard against unwinds in queue-based `Once`) - #161186 (miri subtree update) - #159855 (std: retry waitid on EINTR in the pidfd wait path) - #161053 (Add regression test for borrow of array drop type in const) - #161073 (Add regression test for path printing with infinitely many visible names) - #161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation) - #161103 (cleanup: rip out unnecessary `iter().last()` and `iter().next()`) - #161136 (Add BPF test for Rust ABI stack arguments) - #161146 (Switch to c8a EC2 runner for auto merges) - #161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore)) - #161181 (Add back flaky gui rustdoc test `tests/rustdoc-gui/headers-color.goml`)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 16, 2026
…uwer Rollup of 17 pull requests Successful merges: - #161017 (Library: enforce clippy deref lints in CI) - #160416 (std: fix unix socket address truncation without a trailing NUL) - #161006 ([CI] Build newer `binutils` before building `gcc`) - #161141 (Add documentation for BPF targets) - #161157 (bootstrap: Move several items out of the crate root) - #161185 (std: guard against unwinds in queue-based `Once`) - #161186 (miri subtree update) - #159855 (std: retry waitid on EINTR in the pidfd wait path) - #160478 (diagnostics: Suggest fn binding type for unstable closure for<> binders) - #161053 (Add regression test for borrow of array drop type in const) - #161073 (Add regression test for path printing with infinitely many visible names) - #161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation) - #161103 (cleanup: rip out unnecessary `iter().last()` and `iter().next()`) - #161136 (Add BPF test for Rust ABI stack arguments) - #161146 (Switch to c8a EC2 runner for auto merges) - #161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore)) - #161181 (Add back flaky gui rustdoc test `tests/rustdoc-gui/headers-color.goml`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 17, 2026
Rollup merge of #161148 - GuillaumeGomez:put-back-gui-test, r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of #152197 You can see the original code of this test in #152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Aug 17, 2026
…uwer Rollup of 17 pull requests Successful merges: - rust-lang/rust#161017 (Library: enforce clippy deref lints in CI) - rust-lang/rust#160416 (std: fix unix socket address truncation without a trailing NUL) - rust-lang/rust#161006 ([CI] Build newer `binutils` before building `gcc`) - rust-lang/rust#161141 (Add documentation for BPF targets) - rust-lang/rust#161157 (bootstrap: Move several items out of the crate root) - rust-lang/rust#161185 (std: guard against unwinds in queue-based `Once`) - rust-lang/rust#161186 (miri subtree update) - rust-lang/rust#159855 (std: retry waitid on EINTR in the pidfd wait path) - rust-lang/rust#160478 (diagnostics: Suggest fn binding type for unstable closure for<> binders) - rust-lang/rust#161053 (Add regression test for borrow of array drop type in const) - rust-lang/rust#161073 (Add regression test for path printing with infinitely many visible names) - rust-lang/rust#161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation) - rust-lang/rust#161103 (cleanup: rip out unnecessary `iter().last()` and `iter().next()`) - rust-lang/rust#161136 (Add BPF test for Rust ABI stack arguments) - rust-lang/rust#161146 (Switch to c8a EC2 runner for auto merges) - rust-lang/rust#161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore)) - rust-lang/rust#161181 (Add back flaky gui rustdoc test `tests/rustdoc-gui/headers-color.goml`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #152197
You can see the original code of this test in #152194 (where it was removed).
The
browser-ui-testupdate comes from GuillaumeGomez/browser-UI-test#759. We can now use theclickcommand to click on anoptioninside aselect(surprisingly enough, it needs to be special-cased in puppeteer...).That update allowed me to replace all the
press-keywith oneclick. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone.cc @notriddle @JonathanBrouwer
r? @Urgau