Rollup of 17 pull requests by JonathanBrouwer · Pull Request #161196 · rust-lang/rust

JonathanBrouwer · 2026-08-16T20:46:30Z

Successful merges:

Library: enforce clippy deref lints in CI #161017 (Library: enforce clippy deref lints in CI)
std: fix unix socket address truncation without a trailing NUL #160416 (std: fix unix socket address truncation without a trailing NUL)
[CI] Build newer binutils before building gcc #161006 ([CI] Build newer binutils before building gcc)
Add documentation for BPF targets #161141 (Add documentation for BPF targets)
bootstrap: Move several items out of the crate root #161157 (bootstrap: Move several items out of the crate root)
std: guard against unwinds in queue-based Once #161185 (std: guard against unwinds in queue-based Once)
miri subtree update #161186 (miri subtree update)
std: retry waitid on EINTR in the pidfd wait path #159855 (std: retry waitid on EINTR in the pidfd wait path)
diagnostics: Suggest fn binding type for unstable closure for<> binders #160478 (diagnostics: Suggest fn binding type for unstable closure for<> binders)
Add regression test for borrow of array drop type in const #161053 (Add regression test for borrow of array drop type in const)
Add regression test for path printing with infinitely many visible names #161073 (Add regression test for path printing with infinitely many visible names)
Add regression test for unstable def_ident_span fingerprint with incremental recompilation #161099 (Add regression test for unstable def_ident_span fingerprint with incremental recompilation)
cleanup: rip out unnecessary iter().last() and iter().next() #161103 (cleanup: rip out unnecessary iter().last() and iter().next())
Add BPF test for Rust ABI stack arguments #161136 (Add BPF test for Rust ABI stack arguments)
Switch to c8a EC2 runner for auto merges #161146 (Switch to c8a EC2 runner for auto merges)
[rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) #161148 ([rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore))
Add back flaky gui rustdoc test tests/rustdoc-gui/headers-color.goml #161181 (Add back flaky gui rustdoc test tests/rustdoc-gui/headers-color.goml)

getsockname(2) and friends do not count the trailing NUL in the length they report on freebsd, netbsd and qnx, and a caller may bind(2) without one anywhere, so shortening the path by one byte dropped its last character. scan for the NUL within the reported length instead, which is the rule unix(7) gives and subsumes the qnx case the old cfg handled. Fixes rust-lang#118925

genmc: rename 'invalid' to 'moot'

This updates the rust-version file to 7dfb9d0.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@7dfb9d0 Filtered ref: rust-lang/miri@5cd9353 Upstream diff: rust-lang/rust@f73951d...7dfb9d0 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

This updates the rust-version file to 4667d75.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@4667d75 Filtered ref: rust-lang/miri@b4685b1 Upstream diff: rust-lang/rust@7dfb9d0...4667d75 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

When `for<'a>` appears on a closure without `closure_lifetime_binder`, suggest rewriting a simple let-bound closure to a stable `for<'a> fn(...)` binding type annotation when that rewrite is safe.

Cover MachineApplicable rewrites, MaybeIncorrect capture cases, and macro-expanded binders where structured suggestions must be suppressed.

…erver [Priroda] Add TCP DAP mode for VS Code attach

…e in const

…he `retain` attribute

JonathanBrouwer · 2026-08-16T20:46:45Z

@bors r+ p=5

rust-bors · 2026-08-16T20:46:47Z

📌 Commit 9692358 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-08-17T02:40:45Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 4h 44m 8s
Pushing 2c39ff4 to main...

github-actions · 2026-08-17T02:43:57Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 34baba5 (parent) -> 2c39ff4 (this PR)

Test differences

Show 50 test diffs

Stage 0

utils::helpers::tests::test_envify: [missing] -> pass (J5)

Stage 1

[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#eb: [missing] -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J2)
[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#el: [missing] -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J2)
os::unix::net::tests::sock_addr_without_trailing_nul: [missing] -> pass (J4)
[run-make] tests/run-make/incr-unstable-fingerprint-def-ident-span: [missing] -> pass (J6)
[ui (polonius)] tests/ui/consts/promotion-drop-type-static-lifetime-86672.rs: [missing] -> pass (J8)
[ui (polonius)] tests/ui/imports/path-with-infinite-visible-names-57500.rs: [missing] -> pass (J8)
[ui] tests/ui/consts/promotion-drop-type-static-lifetime-86672.rs: [missing] -> pass (J9)
[ui] tests/ui/imports/path-with-infinite-visible-names-57500.rs: [missing] -> pass (J9)
[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#eb: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J11)
[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#el: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J11)

Stage 2

[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#eb: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J0)
[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#el: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 23.0.0) (J0)
[ui] tests/ui/consts/promotion-drop-type-static-lifetime-86672.rs: [missing] -> pass (J1)
[ui] tests/ui/imports/path-with-infinite-visible-names-57500.rs: [missing] -> pass (J1)
[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#eb: [missing] -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J3)
[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#el: [missing] -> ignore (ignored when the LLVM version 22.1.2 is older than 23.0.0) (J3)
[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#eb: [missing] -> pass (J7)
[assembly] tests/assembly-llvm/bpf-more-than-five-args.rs#el: [missing] -> pass (J7)
[run-make] tests/run-make/incr-unstable-fingerprint-def-ident-span: [missing] -> ignore (ignored when cross-compiling) (J10)
[run-make] tests/run-make/incr-unstable-fingerprint-def-ident-span: [missing] -> pass (J12)
os::unix::net::tests::sock_addr_without_trailing_nul: [missing] -> pass (J13)

Additionally, 28 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2c39ff499469be916d4e45506d1afed69bbaddb7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-2: 21m -> 34m 23s (+63.7%)
dist-aarch64-linux: 1h 55m -> 2h 55m (+51.9%)
dist-x86_64-linux: 1h 57m -> 1h 2m (-46.4%)
x86_64-gnu-llvm-21-1: 50m 45s -> 31m 16s (-38.4%)
x86_64-msvc-ext3: 1h 15m -> 1h 43m (+36.2%)
dist-aarch64-apple: 2h 13m -> 1h 26m (-35.1%)
dist-i686-linux: 1h 43m -> 2h 19m (+34.5%)
x86_64-msvc-ext2: 1h 19m -> 1h 45m (+32.6%)
pr-check-1: 20m 35s -> 27m 17s (+32.6%)
x86_64-gnu-llvm-21-3: 1h 21m -> 1h 45m (+29.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-17T03:22:38Z

Finished benchmarking commit (2c39ff4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.3%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	1.6%	[0.8%, 2.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.3%	[4.3%, 4.3%]	1

Cycles

Results (secondary -9.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-12.0%	[-30.3%, -2.7%]	6
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 455.832s -> 457.537s (0.37%)
Artifact size: 399.69 MiB -> 398.93 MiB (-0.19%)

rust-bors · 2026-08-17T03:45:37Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#161017	Library: enforce clippy deref lints in CI	`3649c54cc535a69861050e3fd2017930b17a27c1` (link)
#160416	std: fix unix socket address truncation without a trailing …	`74cd6ec611430121c72e5b85212fc96d56abe7dd` (link)
#161006	[CI] Build newer `binutils` before building `gcc`	`3d9fe1d2a02dad20764680dac0e0b51cfd2ff70a` (link)
#161141	Add documentation for BPF targets	`165b34e566e4220bc49a68b08d48dd9b09398263` (link)
#161157	bootstrap: Move several items out of the crate root	`370cd7d13a3aca98dd10bc8a1f9da60009029a04` (link)
#161185	std: guard against unwinds in queue-based `Once`	`5e7d723d5af98f281a303460bd50cb735404ab5d` (link)
#161186	miri subtree update	`8ab601b5f6db6a37ae747cb9c6d5378e6c5cf5df` (link)
#159855	std: retry waitid on EINTR in the pidfd wait path	`858293c8e18c8f7bb451f40ddb9cdfab3ae27e79` (link)
#160478	diagnostics: Suggest fn binding type for unstable closure f…	`93bbbffa9d9f0e8c7b270ed6a4198125d70b3cae` (link)
#161053	Add regression test for borrow of array drop type in const	`756d34e8a24b86a9cc3f009a0670684fc34263d7` (link)
#161073	Add regression test for path printing with infinitely many …	`544e3ef70f90629ab7b4d110de2be9478c6e1c1a` (link)
#161099	Add regression test for unstable def_ident_span fingerprint…	`3533128274ec94287663839b6810c688dbfe4688` (link)
#161103	cleanup: rip out unnecessary `iter().last()` and `iter().ne…	`78280033a0e832406bb746ad5137a4a29934d86b` (link)
#161136	Add BPF test for Rust ABI stack arguments	`4d040263559de1fb2638606ccab777ef8e809082` (link)
#161146	Switch to c8a EC2 runner for auto merges	`35c806f22ec1ac07c993b769907a669d299eb5a7` (link)
#161148	[rustdoc] Put back one removed flaky GUI test (which hopefu…	`03292986d1a553fa2d52cb48869d487b652460c2` (link)
#161181	Add back flaky gui rustdoc test `tests/rustdoc-gui/headers-…	`8a2e275f6079b9cefac72d8b6a906b31ef1e24c1` (link)

parent commit: 34baba5394

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

valentynkit and others added 30 commits July 24, 2026 20:19

std: retry waitid on EINTR in the pidfd wait path

a401851

genmc: rename 'invalid' to 'moot'

99f42a7

Merge pull request rust-lang#5244 from RalfJung/genmc-moot

2d4a4f7

genmc: rename 'invalid' to 'moot'

Prepare for merging from rust-lang/rust

a6ed3af

This updates the rust-version file to 7dfb9d0.

Merge pull request rust-lang#5248 from rust-lang/rustup-2026-08-08

1a0bccf

Automatic Rustup

Prepare for merging from rust-lang/rust

ca79456

This updates the rust-version file to 4667d75.

Merge pull request rust-lang#5249 from rust-lang/rustup-2026-08-09

8ca43d6

Automatic Rustup

Suggest moving for<> closure binders onto fn binding types

6c2d6a6

When `for<'a>` appears on a closure without `closure_lifetime_binder`, suggest rewriting a simple let-bound closure to a stable `for<'a> fn(...)` binding type annotation when that rewrite is safe.

Add UI coverage for closure for<> binder binding suggestions

ef35326

Cover MachineApplicable rewrites, MaybeIncorrect capture cases, and macro-expanded binders where structured suggestions must be suppressed.

[Priroda] Generalize DAP session transport

bdbf95a

[Priroda] Add DAP TCP frontend transport

4f63153

[Priroda] Wire --port to DAP TCP mode

2c7b682

[Priroda] Add VS Code DAP launch template

d93b7a8

Build newer binutils before building gcc

377ef9f

clippy::needless_borrow

46eb4fd

clippy::op_ref

ddd8fa0

clippy::borrow_deref_ref

fafcb2b

clippy::explicit_auto_deref

d9d6acf

Library: enforce clippy deref lints in CI

5653e8f

Ignore clippy lint in backtrace submodule

7f74e59

[Priroda] Exit cleanly on DAP TCP setup failures

d7526fc

[Priroda] Clarify VS Code debug type requirement

df2fe1f

[Priroda] Run the VS Code task through cargo

0af72e4

Merge pull request rust-lang#5251 from moabo3li/priroda-vscode-debugs…

90f126a

…erver [Priroda] Add TCP DAP mode for VS Code attach

Add regression test for static lifetime of borrowed array of Drop typ…

7bbe5d6

…e in const

Add extra checks to ensure GCC and binutils have needed support for t…

748a319

…he `retain` attribute

Display generated asm in case it failed

487e0e0

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2026

rust-bors Bot merged commit 2c39ff4 into rust-lang:main Aug 17, 2026
14 checks passed

rustbot added this to the 1.100.0 milestone Aug 17, 2026

Navigation Menu

Uh oh!

Uh oh!

Rollup of 17 pull requests - #161196

Rollup of 17 pull requests#161196
rust-bors[bot] merged 93 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-JHCyFaw

JonathanBrouwer commented Aug 16, 2026

Uh oh!

JonathanBrouwer commented Aug 16, 2026

Uh oh!

rust-bors Bot commented Aug 16, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 17, 2026

Stage 0

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 17, 2026

Uh oh!

rust-bors Bot commented Aug 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Aug 16, 2026

Uh oh!

JonathanBrouwer commented Aug 16, 2026

Uh oh!

rust-bors Bot commented Aug 16, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 17, 2026

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 17, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors Bot commented Aug 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants