3di | Making and reviewing a PR#6967
Merged
gbiggs merged 50 commits intoJul 16, 2026
Merged
Conversation
…ng-a-PR.rst Co-authored-by: Katherine Scott <katherineAScott@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ood-3di/ros2_documentation into making-reviewing-a-pr
…ood-3di/ros2_documentation into making-reviewing-a-pr
keithkirkwood-3di
changed the title
Collaborator
|
Before I review this, are you sure you don't just want to reopen #6892? It was basically ready to go. |
Contributor
Author
|
@kscottz Yes, if you could review here, please? |
|
@keithkirkwood-3di Are there any differences between this PR and the end result of the one Kat already looked at, #6892 ? |
fujitatomoya
approved these changes
Jul 15, 2026
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
i think new section looks good, and removes/redirects the overlapping content from else where.
Contributor
Author
Hello - no, there should be no difference, I had actioned all the comments and have simply pushed all the commits onto this new branch. Again, sorry for the trouble! |
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
gbiggs
approved these changes
Jul 16, 2026
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ng-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…ewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
…enrobotics/ros2_documentation into making-reviewing-a-pr
gbiggs
approved these changes
Jul 16, 2026
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create new how-to articles for Making a pull request and Reviewing a pull request under new section Contributing to code.
These draw from several existing articles, refactoring the content and removing from the original location.
There will be an action at the end of the tickets under this issue to clean up, so that we don’t end up with any duplicates or dead ends.
Related to: #6828
Did you use Generative AI?
No
Additional Information
Documentation updates from 3di Information Solutions, agreed with Geoff and Tully.