Skip to content

3di | Making and reviewing a PR (backport #6967)#6995

Open
mergify[bot] wants to merge 1 commit into
humblefrom
mergify/bp/humble/pr-6967
Open

3di | Making and reviewing a PR (backport #6967)#6995
mergify[bot] wants to merge 1 commit into
humblefrom
mergify/bp/humble/pr-6967

Conversation

@mergify

@mergify mergify Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Create new how-to articles for Making a pull request and Reviewing a pull request under new section Contributing to code.

These draw from several existing articles, refactoring the content and removing from the original location.

There will be an action at the end of the tickets under this issue to clean up, so that we don’t end up with any duplicates or dead ends.

Related to: #6828

Did you use Generative AI?

No

Additional Information

Documentation updates from 3di Information Solutions, agreed with Geoff and Tully.


This is an automatic backport of pull request #6967 done by Mergify.

* OPENR-99: Refactor and create new articles for making and reviewing a PR

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Katherine Scott <katherineAScott@gmail.com>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* OPENR-100: Updates from review in PR

* OPENR-99: Fix linter error of trailing whitespace

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* OPENR-100: More review updates to articles from community contributors

* OPENR-100: Add information about types of comments

* OPENR-100: Updates to Reviewing a PR for clarity/brevity

* OPENR-100: Updates to xrefs and related content

* OPENR-100: Fix linter error at end of file

* Correct broken references

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>

* OPENR-100: Fix broken doc links to Governance

---------

Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com>
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Co-authored-by: Katherine Scott <katherineAScott@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
(cherry picked from commit a6fdb55)

# Conflicts:
#	source/How-To-Guides/Core-maintainer-guide.rst
#	source/The-ROS2-Project/Contributing.rst
@mergify

mergify Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of a6fdb55 has failed:

On branch mergify/bp/humble/pr-6967
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit a6fdb553.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   source/Contact.rst
	new file:   source/The-ROS2-Project/Contributing/Contributing-to-code.rst
	new file:   source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst
	new file:   source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst
	modified:   source/The-ROS2-Project/Contributing/Developer-Guide.rst

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   source/How-To-Guides/Core-maintainer-guide.rst
	both modified:   source/The-ROS2-Project/Contributing.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot added the conflicts label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant