3di | Making and reviewing a PR (backport #6967)#6995
Open
mergify[bot] wants to merge 1 commit into
Open
Conversation
* OPENR-99: Refactor and create new articles for making and reviewing a PR * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Katherine Scott <katherineAScott@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * OPENR-100: Updates from review in PR * OPENR-99: Fix linter error of trailing whitespace * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * OPENR-100: More review updates to articles from community contributors * OPENR-100: Add information about types of comments * OPENR-100: Updates to Reviewing a PR for clarity/brevity * OPENR-100: Updates to xrefs and related content * OPENR-100: Fix linter error at end of file * Correct broken references Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Making-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * Update source/The-ROS2-Project/Contributing/Contributing-to-code/Reviewing-a-PR.rst Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> * OPENR-100: Fix broken doc links to Governance --------- Signed-off-by: Keith Kirkwood <keith.kirkwood@3di-info.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> Co-authored-by: Katherine Scott <katherineAScott@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> (cherry picked from commit a6fdb55) # Conflicts: # source/How-To-Guides/Core-maintainer-guide.rst # source/The-ROS2-Project/Contributing.rst
Contributor
Author
|
Cherry-pick of a6fdb55 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create new how-to articles for Making a pull request and Reviewing a pull request under new section Contributing to code.
These draw from several existing articles, refactoring the content and removing from the original location.
There will be an action at the end of the tickets under this issue to clean up, so that we don’t end up with any duplicates or dead ends.
Related to: #6828
Did you use Generative AI?
No
Additional Information
Documentation updates from 3di Information Solutions, agreed with Geoff and Tully.
This is an automatic backport of pull request #6967 done by Mergify.