Repository navigation
[v7] Fix RSC discovery navigation race - #15799
Merged
Merged
Conversation
(cherry picked from commit 8237181)
Contributor
Preview Build AvailablePreview builds have been created for this PR. You can install pnpm install "remix-run/react-router#preview/pr-15799&path:packages/react-router"And/or install other packages via: pnpm install "remix-run/react-router#preview/pr-15799&path:packages/react-router-dev"
pnpm install "remix-run/react-router#preview/pr-15799&path:packages/react-router-express"
pnpm install "remix-run/react-router#preview/pr-15799&path:packages/react-router-node"
pnpm install "remix-run/react-router#preview/pr-15799&path:packages/react-router-serve"These preview builds will be updated automatically as you push new commits. |
Contributor
|
The preview branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent false 404s in RSC Framework and RSC Data modes when navigation overlaps eager route discovery. Cache discovered paths only after the streamed route definitions have resolved and been installed, so navigation cannot skip discovery while those routes are still missing.
Includes a regression that holds the first manifest stream open while navigating, plus an unstable change file. Split from #15792 and targets
v7. The equivalent v8 fix is #15801.Authored by an AI agent on behalf of @brophdawg11