Repository navigation
Run full CI on v7 pushes and stabilize integration tests - #15792
Merged
Merged
Conversation
Contributor
Preview Build AvailablePreview builds have been created for this PR. You can install pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router"And/or install other packages via: pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router-dev"
pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router-express"
pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router-node"
pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router-serve"These preview builds will be updated automatically as you push new commits. |
brophdawg11
marked this pull request as ready for review
November 19, 2026 20:12
This was referenced Nov 19, 2026
Contributor
|
The preview branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the full branch integration matrix and build/typecheck/lint/unit-test workflow on pushes to
v7, using the existingmaintriggers and path filters.Fix test isolation and synchronization issues identified while investigating Firefox failures from #15742 and this PR:
NODE_ENVafter error-sanitization tests. Assigningundefinedleaked the string"undefined", causing later RSC fixtures to build incompatible JSX and return 500s.The runtime fixes and their regression coverage have been split into independent PRs:
v7) and Fix RSC discovery navigation race #15801 (main/ v8).v7);mainalready has equivalent manifest handling. This runtime bug was exposed after correcting the fixture's preview flag and was not established as the cause of the original intermittent failure.The HMR failure from #15742 has not reproduced in the investigation; no HMR-specific fix is claimed.
Authored by an AI agent on behalf of @brophdawg11