Skip to content

Run full CI on v7 pushes and stabilize integration tests - #15792

Merged
brophdawg11 merged 11 commits into
v7from
brophdawg11/codex-v7-full-ci-firefox
Nov 20, 2026
Merged

brophdawg11 merged 11 commits into
v7from
brophdawg11/codex-v7-full-ci-firefox

Conversation

@brophdawg11

@brophdawg11 brophdawg11 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Run the full branch integration matrix and build/typecheck/lint/unit-test workflow on pushes to v7, using the existing main triggers and path filters.

Fix test isolation and synchronization issues identified while investigating Firefox failures from #15742 and this PR:

  • Delete an originally absent NODE_ENV after error-sanitization tests. Assigning undefined leaked the string "undefined", causing later RSC fixtures to build incompatible JSX and return 500s.
  • Disable the Workers inspector in Cloudflare fixtures to prevent shared-port collisions during concurrent startup.
  • Await updated loader output in middleware, pass-through request, and CSR request tests.
  • Await hash scrolling instead of taking an immediate position snapshot; those assertions also caused Chromium CI retries.

The runtime fixes and their regression coverage have been split into independent PRs:

The HMR failure from #15742 has not reproduced in the investigation; no HMR-specific fix is claimed.

Authored by an AI agent on behalf of @brophdawg11

@brophdawg11 brophdawg11 added the github-actions Pull requests that update GitHub Actions code label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Preview Build Available

Preview builds have been created for this PR. You can install react-router using:

pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router"

And/or install other packages via:

pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router-dev"
pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router-express"
pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router-node"
pnpm install "remix-run/react-router#preview/pr-15792&path:packages/react-router-serve"

These preview builds will be updated automatically as you push new commits.

@brophdawg11 brophdawg11 changed the title Run full CI on v7 pushes and investigate Firefox flakes Run full CI on v7 pushes and fix Firefox flakes Nov 18, 2026
Move the v7 RSC discovery fix to #15799 and the preview prerender manifest fix to #15800, including their tests and change files. Keep this branch focused on full CI coverage and test reliability.
@brophdawg11 brophdawg11 changed the title Run full CI on v7 pushes and fix Firefox flakes Run full CI on v7 pushes and stabilize integration tests Nov 19, 2026
@brophdawg11
brophdawg11 merged commit ab4f7d5 into v7 Nov 20, 2026
10 checks passed
@brophdawg11
brophdawg11 deleted the brophdawg11/codex-v7-full-ci-firefox branch November 20, 2026 17:28
@github-actions

Copy link
Copy Markdown
Contributor

The preview branch preview/pr-15792 has been deleted now that this PR is merged/closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions Pull requests that update GitHub Actions code pkg:@react-router/dev pkg:react-router v7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant