Skip to content

Fix last line hidden in split-screen with 3-button navigation (#3058) - #4044

Open
mohamedelghazali wants to merge 5 commits into
quran:mainfrom
mohamedelghazali:fix/split-screen-bottom-line-3058
Open

mohamedelghazali wants to merge 5 commits into
quran:mainfrom
mohamedelghazali:fix/split-screen-bottom-line-3058

Conversation

@mohamedelghazali

Copy link
Copy Markdown

Fixes #3058

Root Causes

  • Missing navigationBars() bottom inset on quran_pager under edge-to-edge.
  • QuranPageLayout / QuranImagePageLayout gated scrollability strictly on ORIENTATION_LANDSCAPE, even when split-screen portrait viewports lack sufficient vertical height.

Changes

  • PagerActivity.kt: Added window insets listener to quran_pager to apply navigationBars() bottom inset under edge-to-edge.
  • QuranPageLayout.java & QuranImagePageLayout.kt: Updated scrollability logic for QuranPageLayout / QuranImagePageLayout (shouldWrapWithScrollView() still keeps QuranTabletImagePageLayout and QuranTranslationPageLayout unchanged).
  • QuranPageLayoutTest.kt: Added unit tests for QuranPageLayout scrolling behavior.

Verification

  • assembleMadaniDebug, lintMadaniDebug, verifySqlDelightMigration, and testMadaniDebug testReleaseUnitTest -PdisableFirebase passed on fork CI.

Set on apply window insets listener for non-restoring ViewPager to update padding based on navigation bar insets.
Add unit tests for QuranPageLayout and QuranTabletImagePageLayout scroll behavior in different configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Last line sometimes hidden in split screen

1 participant