Repository navigation
Fix last line hidden in split-screen with 3-button navigation (#3058) - #4044
Open
mohamedelghazali wants to merge 5 commits into
Open
mohamedelghazali wants to merge 5 commits into
mohamedelghazali wants to merge 5 commits into
Conversation
Set on apply window insets listener for non-restoring ViewPager to update padding based on navigation bar insets.
Add unit tests for QuranPageLayout and QuranTabletImagePageLayout scroll behavior in different configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3058
Root Causes
navigationBars()bottom inset onquran_pagerunder edge-to-edge.QuranPageLayout/QuranImagePageLayoutgated scrollability strictly onORIENTATION_LANDSCAPE, even when split-screen portrait viewports lack sufficient vertical height.Changes
PagerActivity.kt: Added window insets listener toquran_pagerto applynavigationBars()bottom inset under edge-to-edge.QuranPageLayout.java&QuranImagePageLayout.kt: Updated scrollability logic forQuranPageLayout/QuranImagePageLayout(shouldWrapWithScrollView()still keepsQuranTabletImagePageLayoutandQuranTranslationPageLayoutunchanged).QuranPageLayoutTest.kt: Added unit tests forQuranPageLayoutscrolling behavior.Verification
assembleMadaniDebug,lintMadaniDebug,verifySqlDelightMigration, andtestMadaniDebug testReleaseUnitTest -PdisableFirebasepassed on fork CI.