Repository navigation
build(app): refactor firebase config to support Gradle configuration … - #3760
Closed
mohamedelghazali wants to merge 1 commit into
Closed
mohamedelghazali wants to merge 1 commit into
mohamedelghazali wants to merge 1 commit into
Conversation
…cache - Replaced the anti-pattern `project.hasProperty` with `providers.gradleProperty().isPresent` to safely check for the `disableFirebase` flag without breaking the configuration cache. - Removed the unsafe `getGradle().startParameter.taskRequests` check which was used to conditionally apply Firebase plugins. This approach causes cache misses in modern Gradle versions. - Updated signing config properties to use the `providers` API for cache safety. This refactoring ensures faster build times and full compatibility with Gradle Configuration Cache, reducing technical debt in the build logic.
Contributor
|
JazakumAllah khairan sorry I am behind on PRs and would have merged yours instead of inadvertently fixing in the pr I merged |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cache
project.hasPropertywithproviders.gradleProperty().isPresentto safely check for thedisableFirebaseflag without breaking the configuration cache.getGradle().startParameter.taskRequestscheck which was used to conditionally apply Firebase plugins. This approach causes cache misses in modern Gradle versions.providersAPI for cache safety.This refactoring ensures faster build times and full compatibility with Gradle Configuration Cache, reducing technical debt in the build logic.