Skip to content

build(app): refactor firebase config to support Gradle configuration … - #3760

Closed
mohamedelghazali wants to merge 1 commit into
quran:mainfrom
mohamedelghazali:patch-4
Closed

mohamedelghazali wants to merge 1 commit into
quran:mainfrom
mohamedelghazali:patch-4

Conversation

@mohamedelghazali

Copy link
Copy Markdown

…cache

  • Replaced the anti-pattern project.hasProperty with providers.gradleProperty().isPresent to safely check for the disableFirebase flag without breaking the configuration cache.
  • Removed the unsafe getGradle().startParameter.taskRequests check which was used to conditionally apply Firebase plugins. This approach causes cache misses in modern Gradle versions.
  • Updated signing config properties to use the providers API for cache safety.

This refactoring ensures faster build times and full compatibility with Gradle Configuration Cache, reducing technical debt in the build logic.

…cache

- Replaced the anti-pattern `project.hasProperty` with `providers.gradleProperty().isPresent` to safely check for the `disableFirebase` flag without breaking the configuration cache.
- Removed the unsafe `getGradle().startParameter.taskRequests` check which was used to conditionally apply Firebase plugins. This approach causes cache misses in modern Gradle versions.
- Updated signing config properties to use the `providers` API for cache safety.

This refactoring ensures faster build times and full compatibility with Gradle Configuration Cache, reducing technical debt in the build logic.
@ahmedre

ahmedre commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

JazakumAllah khairan sorry I am behind on PRs and would have merged yours instead of inadvertently fixing in the pr I merged

@mohamedelghazali

mohamedelghazali commented Nov 19, 2026 •

Copy link
Copy Markdown
Author

No worries at all BROTHER I was simply trying to focus on solving real issues, and I believe these solutions genuinely deserve your review: #4044 and #4045. JazakAllahu khairan for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants