Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.quran.labs.androidquran.common.audio.util

import android.os.Build
import com.quran.data.di.AppScope
import com.quran.data.model.audio.Qari
import com.quran.labs.androidquran.common.audio.model.QariItem
Expand All @@ -9,14 +10,18 @@ import dev.zacsweers.metro.Inject
@ContributesBinding(AppScope::class)
class QuranAudioExtensionDecider @Inject constructor() : AudioExtensionDecider {

/** Onyx BOOX firmware 4.2+ cannot decode opus, so force mp3 there. https://github.com/quran/quran_android/issues/4018 */
internal fun isBooxDevice(): Boolean =
"onyx".equals(Build.MANUFACTURER, ignoreCase = true)

/**
* Returns the audio file extension for a given Qari.
* For today, if the Qari has an opus URL, it returns "opus", otherwise it returns "mp3". In
* the future, this might depend on more issues, such as a global preference, or the presence
* of a specific audio file type for the qari already downloaded.
*/
override fun audioExtensionForQari(qari: Qari): String {
return if (qari.opusUrl != null) "opus" else "mp3"
return if (qari.opusUrl != null && !isBooxDevice()) "opus" else "mp3"
}

/**
Expand All @@ -26,7 +31,7 @@ class QuranAudioExtensionDecider @Inject constructor() : AudioExtensionDecider {
* of a specific audio file type for the qari already downloaded.
*/
override fun audioExtensionForQari(qariItem: QariItem): String {
return if (qariItem.opusUrl != null) "opus" else "mp3"
return if (qariItem.opusUrl != null && !isBooxDevice()) "opus" else "mp3"
}

/**
Expand All @@ -35,7 +40,7 @@ class QuranAudioExtensionDecider @Inject constructor() : AudioExtensionDecider {
* for new downloads/streaming.
*/
override fun allowedAudioExtensions(qari: Qari): List<String> {
return if (qari.opusUrl != null) listOf("opus", "mp3") else listOf("mp3")
return if (qari.opusUrl != null && !isBooxDevice()) listOf("opus", "mp3") else listOf("mp3")
}

/**
Expand All @@ -44,7 +49,11 @@ class QuranAudioExtensionDecider @Inject constructor() : AudioExtensionDecider {
* for new downloads/streaming.
*/
override fun allowedAudioExtensions(qariItem: QariItem): List<String> {
return if (qariItem.opusUrl != null) listOf("opus", "mp3") else listOf("mp3")
return if (qariItem.opusUrl != null && !isBooxDevice()) {
listOf("opus", "mp3")
} else {
listOf("mp3")
}
}

}