Skip to content

audio: force mp3 on Onyx BOOX devices that cannot decode opus - #4036

Open
Mubashir78 wants to merge 1 commit into
quran:mainfrom
Mubashir78:fix/4018-boox-mp3
Open

Mubashir78 wants to merge 1 commit into
quran:mainfrom
Mubashir78:fix/4018-boox-mp3

Conversation

@Mubashir78

Copy link
Copy Markdown

Fixes #4018

Summary

Onyx BOOX firmware 4.2 dropped native opus decoding in its Android runtime, so on those devices new downloads and streaming of opus audio are completely silent, while mp3 from the same qaris plays fine. This was confirmed by the reporter: Basfar (mp3 only) works, Minshawi and Abdul Basit (opus for new downloads) fail.

This implements the device workaround suggested by @ahmedre in the issue: QuranAudioExtensionDecider now prefers and allows opus only on devices that are not Onyx BOOX. Detection reads Build.MANUFACTURER with a null-safe, case-insensitive comparison.

Verification

  • No behavior change on non-BOOX devices; existing unit tests for the decider are unaffected (Build.MANUFACTURER is null in local unit tests and the comparison treats null as not-BOOX).
  • I could not run a Gradle build or an instrumented test on my current machine (no Android SDK at the moment), so CI review is needed. On-device verification with the reporter would also be welcome, especially to confirm the manufacturer string on the Palma 2 Pro.

Happy to adjust the detection if BOOX reports a different manufacturer value on some models.

Issue quran#4018. Onyx BOOX firmware 4.2 dropped native opus decoding in its
Android runtime, so on those devices new downloads and streaming of opus
audio are silently silent, while mp3 (which the same qaris expose) works.

audioExtensionForQari() and allowedAudioExtensions() now only prefer or
allow opus when the device is not an Onyx BOOX device. Detection reads
Build.MANUFACTURER and is null-safe, so non-BOOX behaviour and existing
unit tests are unchanged.

Device-forced mp3 suggested by maintainer ahmedre in the issue thread.

(cherry picked from commit 9fd45aa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post-3.6.1 versions fail to download/stream new audio or play un-cached recitations on Android 15 / E-Ink runtimes (Regression)

1 participant