Skip to content

fix(ship): truncate long PR titles so row controls don't overflow #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prellr merged 1 commit into from
Jun 27, 2026
Merged

fix(ship): truncate long PR titles so row controls don't overflow #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/views/ship/components/create-release-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,13 +462,13 @@ export function CreateReleaseDialog({
key={pr.id}
className="flex items-center gap-2 py-1 text-muted-foreground"
>
<span className="tabular-nums">#{pr.number}</span>
<span className="shrink-0 tabular-nums">#{pr.number}</span>
<span className="min-w-0 flex-1 truncate text-foreground">
{pr.title}
</span>
<span
className={cn(
"rounded px-1.5 py-0.5 text-[11px] font-medium uppercase tracking-wide",
"shrink-0 rounded px-1.5 py-0.5 text-[11px] font-medium uppercase tracking-wide",
level === "critical" &&
"bg-destructive/15 text-destructive",
level === "high" &&
Expand Down
8 changes: 4 additions & 4 deletions packages/views/ship/components/ship-release-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,13 +933,13 @@ export function ShipReleasePage({ releaseId }: ShipReleasePageProps) {
href={pr.html_url}
target="_blank"
rel="noopener noreferrer"
className="group/prlink flex flex-1 items-center gap-2 hover:underline"
className="group/prlink flex min-w-0 flex-1 items-center gap-2 hover:underline"
data-testid="release-pr-row-link"
>
<span className="tabular-nums text-muted-foreground">
<span className="shrink-0 tabular-nums text-muted-foreground">
#{pr.number}
</span>
<span className="truncate">{pr.title}</span>
<span className="min-w-0 flex-1 truncate">{pr.title}</span>
<ExternalLink
className="size-3 shrink-0 text-muted-foreground opacity-0 transition-opacity group-hover/prlink:opacity-100"
aria-hidden
Expand All @@ -963,7 +963,7 @@ export function ShipReleasePage({ releaseId }: ShipReleasePageProps) {
{t(($) => $.releases.merge.retry_button)}
</Button>
)}
<span className="text-[10px] uppercase tracking-wide text-muted-foreground">
<span className="shrink-0 text-[10px] uppercase tracking-wide text-muted-foreground">
{pr.risk_level ?? "medium"}
</span>
{isAssembling && (
Expand Down
Loading