Repository navigation
fix(ship): truncate long PR titles so row controls don't overflow - #214
Merged
Merged
Conversation
Long PR titles (the square-mapping PRs carry "(Variations/Items/Auto) + … (ROA-NNNN)") pushed the trailing controls off the right edge: - Release detail PR row: the `<a>` was `flex flex-1` without `min-w-0`, and the title span had bare `truncate` (no `flex-1 min-w-0`), so it couldn't shrink — the merge-state pill, risk badge, and remove ✕ got shoved past the edge. Added `min-w-0` to the link, `min-w-0 flex-1 truncate` to the title, and `shrink-0` to the `#number` + risk badge. - Create-release dialog row: title already truncated; hardened with `shrink-0` on the `#number` + risk pill so they can't be squeezed at narrow widths. views typecheck + eslint clean; ship tests green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long PR titles pushed the trailing controls off the right edge of the row (visible on the release detail page and the Create-release modal).
<a>wasflex flex-1withoutmin-w-0, and the title span had baretruncate— so it couldn't shrink and shoved the merge-state pill / risk badge / remove ✕ past the edge. Addedmin-w-0to the link,min-w-0 flex-1 truncateto the title,shrink-0to#number+ risk badge.shrink-0on#number+ the risk pill.Test plan
🤖 Generated with Claude Code