Adgeneration: rewrite adapter to match Prebid.js v1.6.6 spec - #4858
Adgeneration: rewrite adapter to match Prebid.js v1.6.6 spec#4858ss-toshihide-tajima wants to merge 1 commit into
Conversation
The adgeneration server-side adapter had not been updated in several years and diverged from the Prebid.js adapter. This change brings it back in parity with Prebid.js v1.6.6 (modules/adgenerationBidAdapter.js): - Switch the endpoint from GET /adsv/v1 (query parameters) to POST /adgen/prebid with a JSON body, the protocol the backend now serves for Prebid traffic - Add native support (site and app); banner is kept - Detect sdktype from the request channel and device.os so the backend can distinguish web, Prebid Mobile Android, and Prebid Mobile iOS traffic - Percent-encode VAST XML embedded in JS literals for Prebid Mobile iOS compatibility - Forward dealid from the backend response as bid.dealid - Rewrite JSON golden files for the new protocol and add a native exemplary test; adapter coverage is 97.6%
|
Hi @bsardo, a gentle follow-up on this PR 🙏 We (Supership) maintain the Adgeneration bidder, and this PR brings the server-side adapter into parity with our Prebid.js adapter — we've been maintaining the Prebid.js side under this same handle (e.g. prebid/Prebid.js#12538, which introduced the endpoint/protocol this PR now adopts on the server side). Is there anything needed from my side to get it into the review queue? One small ask in the meantime: since this is our first contribution to this repo, the Validate and adapter-code-coverage workflows are still awaiting maintainer approval to run. Could someone approve the workflow runs so the CI results are visible? ( Happy to address any feedback. The companion docs PR is prebid/prebid.github.io#6665. |
Summary
This PR modernizes the Adgeneration adapter, which has not been updated in several years and has diverged from our Prebid.js adapter. It brings the server-side adapter into parity with Prebid.js v1.6.6 (
modules/adgenerationBidAdapter.js) and moves it to the endpoint our ad server now serves for Prebid traffic.We (Supership Inc.) are the maintainer of this bidder (
ssp-ope@supership.jp).Changes
GET /adsv/v1(query parameters) toPOST https://d.socdm.com/adgen/prebid(JSON body) — the same protocol the Prebid.js adapter usessupportedMediaTypes: [BANNER, NATIVE]): VAST creatives are delivered wrapped as bannerext.prebid.channel/BidRequest.Appanddevice.os, and forward it as thesdktypequery parameter (web / Prebid Mobile Android / Prebid Mobile iOS) so the backend can distinguish delivery pathsdealidfrom the backend response asbid.dealidadapterper the repository semgrep conventionsPublisher impact
None expected. The bidder params are unchanged (
id, required, string). PBS hosts running older versions keep working: the backend continues to serve the legacy/adsv/v1endpoint during the transition.Testing
./validate.sh --nofmt --cov --race 10passes locallyDocs
prebid/prebid.github.io#6665 (companion docs update:
pbs: true,pbs_app_supported: true,media_types: banner, native)