Adgeneration: rewrite adapter to match Prebid.js v1.6.6 spec (upstream 提出候補) - #13
Open
ss-toshihide-tajima wants to merge 1 commit into
Open
Adgeneration: rewrite adapter to match Prebid.js v1.6.6 spec (upstream 提出候補)#13ss-toshihide-tajima wants to merge 1 commit into
ss-toshihide-tajima wants to merge 1 commit into
Conversation
The adgeneration server-side adapter had not been updated in several years and diverged from the Prebid.js adapter. This change brings it back in parity with Prebid.js v1.6.6 (modules/adgenerationBidAdapter.js): - Switch the endpoint from GET /adsv/v1 (query parameters) to POST /adgen/prebid with a JSON body, the protocol the backend now serves for Prebid traffic - Add native support (site and app); banner is kept - Detect sdktype from the request channel and device.os so the backend can distinguish web, Prebid Mobile Android, and Prebid Mobile iOS traffic - Percent-encode VAST XML embedded in JS literals for Prebid Mobile iOS compatibility - Forward dealid from the backend response as bid.dealid - Rewrite JSON golden files for the new protocol and add a native exemplary test; adapter coverage is 97.6%
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 8, 2026
ss-toshihide-tajima
changed the base branch from
upstream-master-20260708
to
master
July 14, 2026 09:15
Collaborator
Author
|
upstream へ提出しました: prebid#4858(docs: prebid/prebid.github.io#6665)。以後のレビュー対応は upstream 側で行います。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the Adgeneration adapter, which has not been updated in several years and has diverged from our Prebid.js adapter. It brings the server-side adapter into parity with Prebid.js v1.6.6 (
modules/adgenerationBidAdapter.js) and moves it to the endpoint our ad server now serves for Prebid traffic.We (Supership Inc.) are the maintainer of this bidder (
ssp-ope@supership.jp).Changes
GET /adsv/v1(query parameters) toPOST https://d.socdm.com/adgen/prebid(JSON body) — the same protocol the Prebid.js adapter usessupportedMediaTypes: [BANNER, NATIVE]): VAST creatives are delivered wrapped as bannerext.prebid.channel/BidRequest.Appanddevice.os, and forward it as thesdktypequery parameter (web / Prebid Mobile Android / Prebid Mobile iOS) so the backend can distinguish delivery pathsdealidfrom the backend response asbid.dealidadapterper the repository semgrep conventionsPublisher impact
None expected. The bidder params are unchanged (
id, required, string). PBS hosts running older versions keep working: the backend continues to serve the legacy/adsv/v1endpoint during the transition.Testing
./validate.sh --nofmt --cov --race 10passes locallyDocs
prebid/prebid.github.io#XXXX (companion docs update:
pbs: true,pbs_app_supported: true,media_types: banner, native)📖 参考日本語訳(レビュー用・upstream には提出しません)
概要(Summary)
この PR は、数年間更新されておらず Prebid.js アダプタと乖離していた Adgeneration アダプタを刷新するものです。サーバーサイドアダプタを Prebid.js v1.6.6(
modules/adgenerationBidAdapter.js)とパリティを取った実装に更新し、当社のアドサーバーが現在 Prebid トラフィック向けに提供しているエンドポイントへ移行します。当社(Supership Inc.)はこの bidder のメンテナーです(
ssp-ope@supership.jp)。変更内容(Changes)
GET /adsv/v1(クエリパラメータ)からPOST https://d.socdm.com/adgen/prebid(JSON body)へ変更 — Prebid.js アダプタと同一のプロトコルsupportedMediaTypes: [BANNER, NATIVE]と同じ判断。VAST 素材は banner としてラップ配信)ext.prebid.channel/BidRequest.Appとdevice.osから判定し、sdktypeクエリパラメータ(web / Prebid Mobile Android / Prebid Mobile iOS)として転送。backend が配信経路を区別できるようにするdealidをbid.dealidとして転送adapterにリネーム媒体側への影響(Publisher impact)
影響なしの想定です。bidder params は変更ありません(
id、必須、string)。旧バージョンの PBS を運用するホストもそのまま動作します: backend は移行期間中、旧/adsv/v1エンドポイントの提供を継続します。テスト(Testing)
./validate.sh --nofmt --cov --race 10(CI と同一コマンド)をローカルで合格ドキュメント(Docs)
prebid/prebid.github.io#XXXX(対応する docs 更新:
pbs: true、pbs_app_supported: true、media_types: banner, native)