Skip to content

Fix: python code gen path to copy #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pingelit merged 5 commits into from
Aug 13, 2026
Merged

Fix: python code gen path to copy #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7887562
Fix: python code gen path to copy
pingelit Aug 12, 2026
01b5de5
Fix quoted Python output paths in CMake copy logic
Copilot Aug 13, 2026
29693a9
Refactor: switch to new hatch CLI
pingelit Aug 13, 2026
80e1131
Fix: new raised errors
pingelit Aug 13, 2026
59d1a32
Fix: python 3.9 is EOL
pingelit Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.10", "3.11", "3.12", "3.13"]
steps:
- uses: actions/checkout@v3
- name: Setup Python
Expand All @@ -165,7 +165,9 @@ jobs:
python -m pip install hatch
- name: Lint
working-directory: ./code-gen
run: hatch fmt --check
run: |
hatch check code
hatch check fmt
- name: type-check
working-directory: ./code-gen
run: hatch run types:check
Expand Down
11 changes: 7 additions & 4 deletions code-gen/generate_data_structures.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,12 +314,15 @@ function (generate_data_structures TARGET_LIBRARY)
endif ()

if (GEN_DATA_OUTPUT_PYTHON)
if (NOT EXISTS ${GEN_DATA_IN_SOURCE_PATH}/${GEN_DATA_OUTPUT_PYTHON})
file (MAKE_DIRECTORY ${GEN_DATA_IN_SOURCE_PATH})
# get the parent directory of the output python file
get_filename_component (GEN_DATA_OUTPUT_PYTHON_PARENT_DIR "${GEN_DATA_IN_SOURCE_PATH}/${GEN_DATA_OUTPUT_PYTHON}" DIRECTORY)

if (NOT EXISTS "${GEN_DATA_OUTPUT_PYTHON_PARENT_DIR}")
file (MAKE_DIRECTORY "${GEN_DATA_OUTPUT_PYTHON_PARENT_DIR}")
endif ()

file (COPY ${GEN_DATA_OUTPUT_BASE_DIR}/${GEN_DATA_OUTPUT_PYTHON}
DESTINATION ${GEN_DATA_IN_SOURCE_PATH}/${GEN_DATA_OUTPUT_PYTHON}
file (COPY "${GEN_DATA_OUTPUT_BASE_DIR}/${GEN_DATA_OUTPUT_PYTHON}"
DESTINATION "${GEN_DATA_OUTPUT_PYTHON_PARENT_DIR}"
)
endif ()

Expand Down
1 change: 1 addition & 0 deletions code-gen/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ ignore = [
"C901", "PLR0911", "PLR0912", "PLR0913", "PLR0915",
# Okay to use random
"S311",
"RUF043",
]
unfixable = [
# Don't touch unused imports
Expand Down
6 changes: 3 additions & 3 deletions code-gen/src/poly_scribe_code_gen/cli/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ def poly_scribe_code_gen() -> int:
raise RuntimeError(msg)

if args.schema:
import importlib.util
import inspect
import sys
import importlib.util # noqa: PLC0415
import inspect # noqa: PLC0415
import sys # noqa: PLC0415

module_name = "idl_module"

Expand Down
2 changes: 1 addition & 1 deletion code-gen/src/poly_scribe_code_gen/py_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def _get_polymorphic_type(type_input: str, inheritance_data: dict[str, list[str]

if union_content:
union_content = [f'"{type_name}"' for type_name in union_content if type_name in defined_types]
return f"Annotated[Union[{', '.join(union_content)}],Field(discriminator=\"type\")]"
return f'Annotated[Union[{", ".join(union_content)}],Field(discriminator="type")]'

return type_input

Expand Down
Loading