Fix: python code gen path to copy - #62
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the in-source Python code generation copy step so the generated Python file is copied into the correct destination directory (rather than treating the destination as a file path).
Changes:
- Compute the parent directory of the intended in-source Python output path.
- Update the
file(COPY ...)destination to that parent directory to avoid invalid file-path destinations.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| file (COPY ${GEN_DATA_OUTPUT_BASE_DIR}/${GEN_DATA_OUTPUT_PYTHON} | ||
| DESTINATION ${GEN_DATA_IN_SOURCE_PATH}/${GEN_DATA_OUTPUT_PYTHON} | ||
| DESTINATION ${GEN_DATA_OUTPUT_PYTHON_PARENT_DIR} |
There was a problem hiding this comment.
Fixed in 01b5de5: I quoted the Python copy path arguments, create the computed parent directory explicitly, and copy into that quoted parent directory.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 78.28% 78.28%
=======================================
Files 11 11
Lines 935 935
Branches 203 203
=======================================
Hits 732 732
Misses 191 191
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: pingelit <22936321+pingelit@users.noreply.github.com>
As the title states.