Skip to content

Fix: python code gen path to copy - #62

Merged
pingelit merged 5 commits into
mainfrom
fix/python-copy
Aug 13, 2026
Merged

Fix: python code gen path to copy#62
pingelit merged 5 commits into
mainfrom
fix/python-copy

Conversation

@pingelit

Copy link
Copy Markdown
Owner

As the title states.

@pingelit
pingelit requested a lite review from Copilot August 12, 2026 19:15
@pingelit pingelit self-assigned this Aug 12, 2026
@pingelit pingelit added the bug Something isn't working label Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the in-source Python code generation copy step so the generated Python file is copied into the correct destination directory (rather than treating the destination as a file path).

Changes:

  • Compute the parent directory of the intended in-source Python output path.
  • Update the file(COPY ...) destination to that parent directory to avoid invalid file-path destinations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread code-gen/generate_data_structures.cmake Outdated
Comment on lines +316 to +325

file (COPY ${GEN_DATA_OUTPUT_BASE_DIR}/${GEN_DATA_OUTPUT_PYTHON}
DESTINATION ${GEN_DATA_IN_SOURCE_PATH}/${GEN_DATA_OUTPUT_PYTHON}
DESTINATION ${GEN_DATA_OUTPUT_PYTHON_PARENT_DIR}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 01b5de5: I quoted the Python copy path arguments, create the computed parent directory explicitly, and copy into that quoted parent directory.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.28%. Comparing base (c6ca03f) to head (59d1a32).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          11       11           
  Lines         935      935           
  Branches      203      203           
=======================================
  Hits          732      732           
  Misses        191      191           
  Partials       12       12           
Flag Coverage Δ
3.10 74.34% <ø> (ø)
3.11 74.34% <ø> (ø)
3.12 74.34% <ø> (ø)
3.13 74.34% <ø> (ø)
3.9 ?
Windows 94.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: pingelit <22936321+pingelit@users.noreply.github.com>
@pingelit
pingelit merged commit 3342c83 into main Aug 13, 2026
16 checks passed
@pingelit
pingelit deleted the fix/python-copy branch August 13, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants