Add planner_dart component for DART planners - #567
Conversation
|
Hey @brianhou, can you take another look? Reviving this now, I've made some fixes so Travis should be satisfied. |
There was a problem hiding this comment.
Looks mostly good! However, what is our current policy on creating a new component? Is it mostly for better organization (in which case it does not have to be a component that can be compiled optionally) or is it based on the dependencies involved? Whichever it is, we should document this. Could you create an issue to discuss, track and add the decision to our code guidelines?
| @@ -0,0 +1,62 @@ | |||
| if(CMAKE_COMPILER_IS_GNUCXX) | |||
| if(OMPL_VERSION VERSION_GREATER 1.2.0 OR OMPL_VERSION VERSION_EQUAL 1.2.0) | |||
| if(Boost_VERSION VERSION_LESS 106501) | |||
There was a problem hiding this comment.
We do not need to check boost version here since this subdirectory does not have ompl code.
There was a problem hiding this comment.
This is related to the below comment as well: this PR is set up for #566. Sorry, I totally should have made that more clear: because the ultimate goal here is deprecating a lot of the old robot/util stuff, we need to move some of the planTo methods that use ompl into this new dart_planner module. That's what #566 starts to do, but we set up the ompl dependency here 😄
| "${PROJECT_NAME}_trajectory" | ||
| "${PROJECT_NAME}_statespace" | ||
| "${PROJECT_NAME}_planner" | ||
| "${PROJECT_NAME}_planner_ompl" |
|
@aditya-vk You have a good question about when to split off a new component. I think the motivation here is a combination of:
If these motivations sound good, I'm happy to create an issue to track this and update our AIKIDO guidelines. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 76.37% 78.69% +2.31%
==========================================
Files 200 170 -30
Lines 7030 6406 -624
==========================================
- Hits 5369 5041 -328
+ Misses 1661 1365 -296 🚀 New features to boost your workflow:
|
This PR creates
planner_dartcomponent and builds all DART planners asplanner_dartcomponent.Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md