bake: free the dev server's JS-thread bundle allocations with the bundle - #39050
Closed
robobun wants to merge 4 commits into
Closed
bake: free the dev server's JS-thread bundle allocations with the bundle#39050robobun wants to merge 4 commits into
robobun wants to merge 4 commits into
Claude / Claude Code Review
completed
Aug 15, 2026 in 18m 12s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/bake/dev-server-memory.test.ts:90-95 |
Test hangs to timeout instead of failing fast if dev server exits between rebuilds |
Annotations
Check warning on line 95 in test/bake/dev-server-memory.test.ts
claude / Claude Code Review
Test hangs to timeout instead of failing fast if dev server exits between rebuilds
nit: The stderr reader only rejects whatever `waiter` is live when the stream closes (line 71); a `waiter` created afterward is never settled. If the server crashes while `waiter === undefined` (e.g. during `liveBlocks()` or right after a resolve), the next `rebuild()` sets a fresh waiter, `Bun.write` succeeds against the temp dir, and `await promise` hangs to the 60s timeout with no stderr dump. Latch the exit error and check it in `rebuild()` (or race `promise` against `stderrClosed`) so the f
Loading