TOML: map date/time values to Temporal, round-trip them through stringify - #37018
Merged
Claude / Claude Code Review
completed
Aug 13, 2026 in 16m 17s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bundler/ParseTask.rs:836-839 |
Loader::Xml is the last remaining new_lazy_export_ast .unwrap() after the class-wide conversion |
Annotations
Check warning on line 839 in src/bundler/ParseTask.rs
claude / Claude Code Review
Loader::Xml is the last remaining new_lazy_export_ast .unwrap() after the class-wide conversion
Follow-on to the (now-addressed) comment at :611: the six sites it named plus the original eight are all converted, but `Loader::Xml` at ParseTask.rs:870 still has `?.unwrap()` — it is now the sole remaining `new_lazy_export_ast` caller out of 14. It doesn't appear in the diff at all, so it was almost certainly introduced by the merge from main (b7a674d9) after the earlier enumeration. Its materialized-XML root cannot contain `toml_datetime`, so the new failure path can't fire, but the same is t
Loading