-
Notifications
You must be signed in to change notification settings - Fork 5k
TOML: map date/time values to Temporal, round-trip them through stringify #37018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,494
−757
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c820de1
TOML: parse date/time values as Temporal objects, stringify them back…
robobun da85b78
Tag EString with the TOML date/time kind instead of adding an AST node
robobun aafc927
Tighten code comments
robobun 9ac6b36
Route the transform-path Temporal reference through globalThis
robobun 4a6ffe8
Share the Temporal literal FFI dispatch, cover the sub-minute offset …
robobun e52bf10
Keep EString's doc comment attached to the struct
robobun 258b0c6
Address review: typed discriminants, classify once, Date precision pa…
robobun e966563
Mangle a globalThis TOML key's var on the transform path
robobun 4af3b09
Share one Expr to JSValue converter between TOML.parse and imports
robobun b0f49a0
Walk the TOML AST iteratively; fail lazy-export parse errors gracefully
robobun 27274c7
Use an absolute entry path and drain stderr in the deep-header test
robobun 5be6ab7
Merge main to pick up Temporal-aware deepEquals (#37024)
robobun 7978392
Compare conformance-suite date/times with plain toEqual
robobun 627f3e3
Convert the remaining lazy-export unwraps; gate the datetime walk to …
robobun b7a674d
Merge remote-tracking branch 'origin/main' into farm/76e35552/toml-te…
dylan-conway ca941ea
Gate the datetime lowering walk to TOML lazy exports; downcast pre-cl…
dylan-conway 25187c8
TOML.stringify: spell year-edge instants with an in-range offset inst…
dylan-conway 1dd8b4f
Address review: single out-of-range sentinel from toTOMLDateTime, tig…
dylan-conway c45d52f
Drop the --no-bundle globalThis key mangling; convert the last lazy-e…
dylan-conway 902aef3
Print TOML date/times on the --no-bundle path as bare Temporal.*.from…
dylan-conway 0a4b019
Classify Temporal values through JSC::temporalType and a shared bun_j…
dylan-conway a3168a5
Merge remote-tracking branch 'origin/main' into farm/76e35552/toml-te…
dylan-conway 48b6af9
Merge remote-tracking branch 'origin/main' into farm/76e35552/toml-te…
dylan-conway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.