TOML: map date/time values to Temporal, round-trip them through stringify - #37018
Merged
Claude / Claude Code Review
completed
Aug 6, 2026 in 22m 50s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/ast/e.rs:1586-1613 |
TomlDateTimeKind enum inserted between EString's doc comment and the struct |
Annotations
Check warning on line 1613 in src/ast/e.rs
claude / Claude Code Review
TomlDateTimeKind enum inserted between EString's doc comment and the struct
The `TomlDateTimeKind` enum is inserted between `EString`'s doc comment (line 1578 `/// JavaScript string literal type` + the `repr(C, align(8))` rationale) and the `#[repr(C, align(8))] pub struct EString` declaration itself. Since `//` comments are whitespace to rustc, the `///` line now attaches to `TomlDateTimeKind` (concatenating into "JavaScript string literal type Discriminants are shared with…"), the arm64-linker `repr` rationale sits above a `repr(u8)` enum, and `EString` loses its rust
Loading