shell: support ReadableStream stdin redirect via SinkHandle - #36895
Open
robobun wants to merge 11 commits into
Open
shell: support ReadableStream stdin redirect via SinkHandle#36895robobun wants to merge 11 commits into
robobun wants to merge 11 commits into
Claude / Claude Code Review
completed
Aug 5, 2026 in 33m 25s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/shell/subproc.rs:134-155 |
Stale SAFETY comments reference removed adopt constructor |
Annotations
Check warning on line 155 in src/runtime/shell/subproc.rs
claude / Claude Code Review
Stale SAFETY comments reference removed `adopt` constructor
🟡 cfdfa8db replaced `unsafe fn FileSinkPtr::adopt` with safe `create`/`create_with_pipe` constructors, but the three SAFETY comments on `impl Deref` (line 170), `impl DerefMut` (line 179), and `impl Drop` (line 189) still read "`adopt` contract — …". `adopt` no longer exists. The invariant they describe (self.0 is a live `FileSink` from `FileSink::create*` with one owned intrusive ref) is still correct — only the constructor name is stale — so nit: reword to "`create*` contract" or state the inv
Loading