-
Notifications
You must be signed in to change notification settings - Fork 5k
shell: support ReadableStream stdin redirect via SinkHandle #36895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
11
commits into
main
Choose a base branch
from
farm/5c784d26/shell-readablestream-sinkhandle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
510c7cd
shell: support ReadableStream stdin redirect via SinkHandle
robobun cada105
address review: propagate FileSink start error, guard source invarian…
robobun 2d0b05b
trim comments per comment-cop
robobun d6317bf
address claude review: teardown spawned child on Writable::init failu…
robobun 0d8f41c
null out_subproc on Sys(e) early return; issue URL in test comment
robobun 0a1fc5b
delete now-unreachable UnexpectedCreatingStdin; Windows Sys(e) uv pip…
robobun ead44ad
rename Bun.file().stream() test to reflect it tests the blob-collapse…
robobun cfdfa8d
refactor shell ReadableStream stdin to drop call-site unsafe
robobun 109c340
trim comments per comment-cop
robobun 3c93103
delete the dead ShellWritable wiring
robobun b7363df
classify every synchronous assign_to_stream throw; format the thrown …
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.