Skip to content

test: drop bookkeeping for GC-observation tests deleted in #35182 (+0 tests, cleanup only) #35402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cirospaciari wants to merge 4 commits into
base: main
Choose a base branch
from
+0 −0
Open

test: drop bookkeeping for GC-observation tests deleted in #35182 (+0 tests, cleanup only) #35402

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29684cc
test: drop bookkeeping for GC-observation tests deleted in #35182
cirospaciari Jul 24, 2026
72c9e2c
test: also drop the expected-durations entries
cirospaciari Jul 24, 2026
057ac83
Merge remote-tracking branch 'origin/main' into claude/cleanup-delete…
robobun Aug 3, 2026
17f49b0
Merge remote-tracking branch 'origin/main' into claude/cleanup-delete…
robobun Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/expectations.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,9 @@
# listener IS removed (verified: listenerCount("secureConnect") === 0 in
# done()) and the object IS collected (test passes 70/70 on darwin and
# glibc Linux); on alpine x64 the FR callback delivery slips past the single
# setImmediate after this PR's added module loads at process startup shift
# the heap layout. The robust fix is gcUntil() rather than a single tick,
# but the file is a verbatim upstream port. Quarantined on the failing

Check warning on line 39 in test/expectations.txt

View check run for this annotation

Claude / Claude Code Review

Orphaned comment block left behind after removing test-tls-connect-memleak.js entry 

Removing the `test-tls-connect-memleak.js` entry deleted only the last two lines of its explanatory comment, leaving lines 29-39 as an orphaned block that now ends mid-sentence ("...Quarantined on the failing") and describes a quarantine entry that no longer exists. Since this PR's whole purpose is dropping stale bookkeeping for the tests #35182 deleted, the entire comment block (from `# Verbatim node v26.3.0 test asserting a FinalizationRegistry callback fires` through `...Quarantined on the fa
Comment thread
claude[bot] marked this conversation as resolved.
Outdated
# linux-x64-musl matrix only; still runs everywhere else (build 63145:
# alpine 3.23 x64 + x64-baseline only).
[ LINUX-X64-MUSL ] test/js/node/test/parallel/test-tls-connect-memleak.js [ FLAKY ] # JSC FinalizationRegistry callback delivery vs setImmediate timing on musl x64

# Both tests mock _handle.setKeepAlive and assert it receives SECONDS
# (libuv's uv_tcp_keepalive convention). In Bun, _handle is the public
Expand Down
17 changes: 0 additions & 17 deletions test/expected-durations.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading