test: drop bookkeeping for GC-observation tests deleted in #35182 (+0 tests, cleanup only) - #35402
Open
cirospaciari wants to merge 4 commits into
Open
test: drop bookkeeping for GC-observation tests deleted in #35182 (+0 tests, cleanup only)#35402cirospaciari wants to merge 4 commits into
cirospaciari wants to merge 4 commits into
Claude / Claude Code Review
completed
Jul 24, 2026 in 6m 2s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/expectations.txt:37-39 |
Orphaned comment block left behind after removing test-tls-connect-memleak.js entry |
Annotations
Check warning on line 39 in test/expectations.txt
claude / Claude Code Review
Orphaned comment block left behind after removing test-tls-connect-memleak.js entry
Removing the `test-tls-connect-memleak.js` entry deleted only the last two lines of its explanatory comment, leaving lines 29-39 as an orphaned block that now ends mid-sentence ("...Quarantined on the failing") and describes a quarantine entry that no longer exists. Since this PR's whole purpose is dropping stale bookkeeping for the tests #35182 deleted, the entire comment block (from `# Verbatim node v26.3.0 test asserting a FinalizationRegistry callback fires` through `...Quarantined on the fa
Loading