test: widen net-mongodb-pattern-leak RSS bound; await the named-pipe GC check - #33725
Open
robobun wants to merge 6 commits into
Open
test: widen net-mongodb-pattern-leak RSS bound; await the named-pipe GC check#33725robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 8, 2026 in 46m 16s
Code review found 1 important issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | packages/bun-usockets/src/loop.c:706-710 |
is_paused eof-defer busy-loops on Linux AF_UNIX (not-shut_down EPOLLHUP variant) |
Annotations
Check failure on line 710 in packages/bun-usockets/src/loop.c
claude / Claude Code Review
is_paused eof-defer busy-loops on Linux AF_UNIX (not-shut_down EPOLLHUP variant)
The `is_paused` defer still busy-loops on Linux **AF_UNIX** when the peer `close()`s: `unix_release_sock()` sets `sk_shutdown = SHUTDOWN_MASK` on our side so `unix_poll()` asserts level-triggered `EPOLLHUP` without `EPOLLERR`, and since we never called `shutdown()` the poll type is still `POLL_TYPE_SOCKET` — so the ungated `is_shut_down` fast-close doesn't fire either, the empty branch does nothing, and `epoll_wait` immediately returns `EPOLLHUP` again at 100% CPU. Pre-PR the `allow_half_open` a
Loading