Skip to content

test: widen net-mongodb-pattern-leak RSS bound; await the named-pipe GC check #33725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 6 commits into
base: main
Choose a base branch
from
+6 −5
Open

test: widen net-mongodb-pattern-leak RSS bound; await the named-pipe GC check #33725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9a2ffa
usockets: defer eof dispatch when on_data paused mid-drain; widen mon…
robobun Jul 8, 2026
8f1cb1c
loop.c: keep the shut_down fast-close ungated by is_paused
robobun Jul 8, 2026
b324515
node-net.test.ts: await the named-pipe TCPSocket GC check and destroy…
robobun Jul 8, 2026
c831742
loop.c: only defer on_end when on_data paused this dispatch (events h…
robobun Jul 8, 2026
3c1f54f
node-net.test.ts: resume via setImmediate so the pause survives past …
robobun Jul 8, 2026
260fbfd
Drop the loop.c is_paused defer; keep only the RSS bound and the name…
robobun Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/js/node/net/net-mongodb-pattern-leak.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,10 @@ describe.each([
expect(messages.listenerCount("data")).toBe(0);
expect(messages.listenerCount("error")).toBeLessThanOrEqual(1);

// RSS round-2 vs round-1: weak signal (mimalloc segment noise) but
// catches anything egregious that heapStats can't see.
const rssBound = isASAN || isDebug ? 32 * 1024 * 1024 : 8 * 1024 * 1024;
// RSS round-2 vs round-1: weak backstop for native leaks heapStats can't
// see. Release CI observed 8-13 MB here with flat heapSize and flat object
// counts (mimalloc + JIT noise); a real native leak at ITER=5000 is 25+ MB.
const rssBound = isASAN || isDebug ? 32 * 1024 * 1024 : 24 * 1024 * 1024;
expect(after2.rss - after1.rss).toBeLessThan(rssBound);
} finally {
sock.destroy();
Expand Down
4 changes: 2 additions & 2 deletions test/js/node/net/node-net.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ it.if(isWindows)(
}

const batch = [];
const before = heapStats().objectTypeCounts.TLSSocket || 0;
const before = heapStats().objectTypeCounts.TCPSocket || 0;
for (let i = 0; i < 100; i++) {
batch.push(test(`\\\\.\\pipe\\test\\${randomUUID()}`));
batch.push(test(`\\\\?\\pipe\\test\\${randomUUID()}`));
Expand All @@ -857,7 +857,7 @@ it.if(isWindows)(
}
}
await Promise.all(batch);
expectMaxObjectTypeCount(expect, "TCPSocket", before);
await expectMaxObjectTypeCount(expect, "TCPSocket", before);
},
20_000,
);
Expand Down
Loading