[master] ACM-35865: CVE-2026-39828 Bump golang.org/x/crypto to v0.52.0 using replace directive (client module)

[shay23bra]

Bump golang.org/x/crypto to v0.52.0 to fix CVE-2026-39828 using a replace directive

Strategy Selection

Strategies Not Applicable

• Direct dependency version bump
  Not applicable: dependency is indirect. Direct version bumps only work for explicitly required modules.

• Direct dependency major version upgrade
  Not applicable: dependency is indirect. Major version upgrades only apply to direct dependencies.

• Indirect dependency fix via parent update
  Exception: unhandled errors in a TaskGroup (3 sub-exceptions)

• Indirect to direct dependency conversion
  Attempted to pin golang.org/x/crypto to a fixed version, but Go reverted it to indirect at v0.0.0-20220622213112-05595931fe9d. No other module requires this version directly, so the explicit requirement was automatically removed by Go's module resolution.

✓ Successful Strategy: Replace directive workaround

Added replace directive to override module resolution. Used as last resort when standard updates fail.

https://redhat.atlassian.net/browse/ACM-35865

---

This PR was automatically generated by the CVE Automation tool.
For questions or issues, reach out in #cve-automation.

Summary by CodeRabbit

• Chores
  • Updated the cryptography component version used by the application for improved consistency and compatibility.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@shay23bra: This pull request references ACM-35865 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Bump golang.org/x/crypto to v0.52.0 to fix CVE-2026-39828 using a replace directive

Strategy Selection

Strategies Not Applicable

• Direct dependency version bump
  Not applicable: dependency is indirect. Direct version bumps only work for explicitly required modules.

• Direct dependency major version upgrade
  Not applicable: dependency is indirect. Major version upgrades only apply to direct dependencies.

• Indirect dependency fix via parent update
  Exception: unhandled errors in a TaskGroup (3 sub-exceptions)

• Indirect to direct dependency conversion
  Attempted to pin golang.org/x/crypto to a fixed version, but Go reverted it to indirect at v0.0.0-20220622213112-05595931fe9d. No other module requires this version directly, so the explicit requirement was automatically removed by Go's module resolution.

✓ Successful Strategy: Replace directive workaround

Added replace directive to override module resolution. Used as last resort when standard updates fail.

https://redhat.atlassian.net/browse/ACM-35865

---

This PR was automatically generated by the CVE Automation tool.
For questions or issues, reach out in #cve-automation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 06b8a316-4f50-47c0-bfa6-d50ffc844323

📥 Commits

Reviewing files that changed from the base of the PR and between d4ff0e8 and b7bba4c.

⛔ Files ignored due to path filters (2)

• client/go.sum is excluded by !**/*.sum
• client/vendor/modules.txt is excluded by !**/vendor/**

📒 Files selected for processing (1)

• client/go.mod

🚧 Files skipped from review as they are similar to previous changes (1)

• client/go.mod

---

Walkthrough

The client Go module adds a replace directive that pins golang.org/x/crypto to version v0.52.0.

Changes

Crypto dependency pin

Layer / File(s)	Summary
Pin x/crypto module client/go.mod	Adds a replacement directive resolving golang.org/x/crypto to v0.52.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

• openshift/image-based-install-operator issue 443 — Also pins golang.org/x/crypto to v0.52.0.
• openshift/origin issue 30621 — Pins golang.org/x/crypto to v0.52.0.
• openshift/installer issue 10170 — Modifies golang.org/x/crypto to version v0.52.0.
• openshift/cluster-baremetal-operator issue 536 — Pins golang.org/x/crypto to v0.52.0.
• openshift/machine-api-provider-azure issue 178 — Pins golang.org/x/crypto to v0.52.0.
• openshift/machine-config-operator issue 5506 — Updates golang.org/x/crypto.
• openshift/cluster-api-provider-ibmcloud issue 141 — Pins golang.org/x/crypto to v0.52.0.

Possibly related PRs

• openshift/assisted-service#10616 — Applies the same golang.org/x/crypto v0.52.0 replacement.
• openshift/assisted-service#10618 — Adds the same dependency pin.

Suggested labels: lgtm

Suggested reviewers: jhernand, giladravid16

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the CVE fix and the x/crypto replace-based version bump in the client module.
Description check	✅ Passed	The description includes the change summary, issue link, motivation, and workaround context, though it doesn't fully follow the template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes module files (go.mod/go.sum/vendor); no Ginkgo test titles were added or modified.
Test Structure And Quality	✅ Passed	No Ginkgo test code changed; only module metadata/vendor files were updated, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	The PR only changes client module dependency files; no new Ginkgo e2e tests or MicroShift-sensitive APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo/e2e tests were added; the PR only changes client module metadata, so SNO compatibility isn’t implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	Only client/go.mod, client/go.sum, and client/vendor/modules.txt changed; diff adds a x/crypto replace and no scheduling manifests/controllers.
Ote Binary Stdout Contract	✅ Passed	PR only updates client go.mod/go.sum/vendor metadata to pin x/crypto; no process-level code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only module files changed (go.mod/go.sum/vendor); no new Ginkgo e2e tests or networking code were added.
No-Weak-Crypto	✅ Passed	PR only changes Go module metadata; no weak-crypto APIs or custom crypto logic appear in the diff.
Container-Privileges	✅ Passed	Only client/go.mod, client/go.sum, and client/vendor/modules.txt changed; no K8s/container manifests or privilege fields were added.
No-Sensitive-Data-In-Logs	✅ Passed	Diff only updates go.mod/go.sum/vendor modules for x/crypto; no logging code or sensitive strings were added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shay23bra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [shay23bra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shay23bra]

/retest

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.48%. Comparing base (fb258fb) to head (b7bba4c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10617      +/-   ##
==========================================
+ Coverage   44.47%   44.48%   +0.01%     
==========================================
  Files         423      423              
  Lines       73327    73327              
==========================================
+ Hits        32614    32622       +8     
+ Misses      37802    37798       -4     
+ Partials     2911     2907       -4     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gamli75]

/retest-required
/lgtm

[openshift-merge-bot]

Scheduling required tests:
/test edge-e2e-ai-operator-ztp-3masters
/test edge-e2e-metal-assisted-4-16
/test edge-e2e-metal-assisted-4-17
/test edge-e2e-metal-assisted-5-control-planes-5-0
/test edge-e2e-metal-assisted-vlan-5-0
/test edge-operator-publish-verify

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-agent-compact-ipv4
/test e2e-agent-compact-ipv4-iso-no-registry

[gamli75]

/override ci/prow/e2e-ai-operator-ztp-3masters

[openshift-ci]

@gamli75: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• ci/prow/e2e-ai-operator-ztp-3masters

Only the following failed contexts/checkruns were expected:

• ci/prow/e2e-agent-compact-ipv4
• ci/prow/e2e-agent-compact-ipv4-iso-no-registry
• ci/prow/edge-ci-index
• ci/prow/edge-e2e-ai-operator-ztp-3masters
• ci/prow/edge-e2e-metal-assisted-4-16
• ci/prow/edge-e2e-metal-assisted-4-17
• ci/prow/edge-e2e-metal-assisted-5-control-planes-5-0
• ci/prow/edge-e2e-metal-assisted-vlan-5-0
• ci/prow/edge-images
• ci/prow/edge-lint
• ci/prow/edge-operator-publish-verify
• ci/prow/edge-unit-test
• ci/prow/edge-verify-generated-code
• ci/prow/images
• ci/prow/mce-images
• ci/prow/okd-scos-images
• ci/prow/verify-deps
• ci/prow/verify-generated-code
• pull-ci-openshift-assisted-service-assisted-version-placeholder-images
• pull-ci-openshift-assisted-service-assisted-version-placeholder-verify-generated-code
• pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
• pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4-iso-no-registry
• pull-ci-openshift-assisted-service-master-edge-ci-index
• pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-3masters
• pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-16
• pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-17
• pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-5-control-planes-5-0
• pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-vlan-5-0
• pull-ci-openshift-assisted-service-master-edge-images
• pull-ci-openshift-assisted-service-master-edge-lint
• pull-ci-openshift-assisted-service-master-edge-operator-publish-verify
• pull-ci-openshift-assisted-service-master-edge-unit-test
• pull-ci-openshift-assisted-service-master-edge-verify-generated-code
• pull-ci-openshift-assisted-service-master-mce-images
• pull-ci-openshift-assisted-service-master-okd-scos-images
• pull-ci-openshift-assisted-service-master-verify-deps
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prow/e2e-ai-operator-ztp-3masters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shay23bra]

/retest

[openshift-ci]

@shay23bra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gamli75]

/lgtm