Skip to content

[master] ACM-35865: CVE-2026-39828 Bump golang.org/x/crypto to v0.52.0 using replace directive (client module)#10659

Closed
shay23bra wants to merge 1 commit into
openshift:masterfrom
shay23bra:cve-CVE-2026-39828-de2c00fe-d40973
Closed

[master] ACM-35865: CVE-2026-39828 Bump golang.org/x/crypto to v0.52.0 using replace directive (client module)#10659
shay23bra wants to merge 1 commit into
openshift:masterfrom
shay23bra:cve-CVE-2026-39828-de2c00fe-d40973

Conversation

@shay23bra

@shay23bra shay23bra commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Bump golang.org/x/crypto to v0.52.0 to fix CVE-2026-39828 using a replace directive

Strategy Selection

Strategies Not Applicable

  • Direct dependency version bump
    Not applicable: dependency is indirect. Direct version bumps only work for explicitly required modules.

  • Direct dependency major version upgrade
    Not applicable: dependency is indirect. Major version upgrades only apply to direct dependencies.

  • Indirect dependency fix via parent update
    Exception: unhandled errors in a TaskGroup (1 sub-exception)

  • Indirect to direct dependency conversion
    Attempted to pin golang.org/x/crypto to a fixed version, but Go reverted it to indirect at v0.0.0-20220622213112-05595931fe9d. No other module requires this version directly, so the explicit requirement was automatically removed by Go's module resolution.

✓ Successful Strategy: Replace directive workaround

Added replace directive to override module resolution. Used as last resort when standard updates fail.

https://redhat.atlassian.net/browse/ACM-35865


This PR was automatically generated by the CVE Automation tool.
For questions or issues, reach out in #cve-automation.

Summary by CodeRabbit

  • Chores
    • Updated the cryptography component version used by the application.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@shay23bra: This pull request references ACM-35865 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Bump golang.org/x/crypto to v0.52.0 to fix CVE-2026-39828 using a replace directive

Strategy Selection

Strategies Not Applicable

  • Direct dependency version bump
    Not applicable: dependency is indirect. Direct version bumps only work for explicitly required modules.

  • Direct dependency major version upgrade
    Not applicable: dependency is indirect. Major version upgrades only apply to direct dependencies.

  • Indirect dependency fix via parent update
    Exception: unhandled errors in a TaskGroup (1 sub-exception)

  • Indirect to direct dependency conversion
    Attempted to pin golang.org/x/crypto to a fixed version, but Go reverted it to indirect at v0.0.0-20220622213112-05595931fe9d. No other module requires this version directly, so the explicit requirement was automatically removed by Go's module resolution.

✓ Successful Strategy: Replace directive workaround

Added replace directive to override module resolution. Used as last resort when standard updates fail.

https://redhat.atlassian.net/browse/ACM-35865


This PR was automatically generated by the CVE Automation tool.
For questions or issues, reach out in #cve-automation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 08cb27dd-4bae-4cd5-a5f5-faf5bb40bc87

📥 Commits

Reviewing files that changed from the base of the PR and between 607d578 and c5891ee.

⛔ Files ignored due to path filters (2)
  • client/go.sum is excluded by !**/*.sum
  • client/vendor/modules.txt is excluded by !**/vendor/**
📒 Files selected for processing (1)
  • client/go.mod

Walkthrough

The client Go module adds a replace directive that pins golang.org/x/crypto to version v0.52.0.

Changes

Crypto dependency configuration

Layer / File(s) Summary
Add crypto module override
client/go.mod
Adds a replace directive mapping golang.org/x/crypto to v0.52.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • openshift/image-based-install-operator#443 — Also updates golang.org/x/crypto to v0.52.0.
  • openshift/origin#30621 — Also updates golang.org/x/crypto for dependency vulnerability remediation.
  • openshift/installer#10170 — Also updates golang.org/x/crypto to v0.52.0.
  • openshift/cluster-api-provider-ibmcloud#141 — Also overrides golang.org/x/crypto to v0.52.0.
  • openshift/cluster-baremetal-operator#536 — Also pins golang.org/x/crypto to v0.52.0.
  • openshift/machine-api-provider-azure#178 — Also updates golang.org/x/crypto to v0.52.0.
  • openshift/machine-config-operator#5506 — Also pins golang.org/x/crypto to v0.52.0.

Possibly related PRs

Suggested labels: approved, size/XS

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and accurately summarizes the x/crypto CVE fix via a replace directive in the client module.
Description check ✅ Passed The description includes the change summary, CVE motivation, issue link, and strategy context, with only minor template sections left sparse.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes module metadata (go.mod/go.sum/vendor) and touches no test files, so it introduces no Ginkgo titles.
Test Structure And Quality ✅ Passed No Ginkgo or other test files changed; the patch only updates dependency metadata, so this check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only changes client go.mod/go.sum/vendor metadata, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only client/go.mod changed; no new or modified Ginkgo/e2e tests were added, so no SNO-specific compatibility issue applies.
Topology-Aware Scheduling Compatibility ✅ Passed Only Go dependency files changed (go.mod, go.sum, vendor/modules.txt); no manifests, operators, or controllers were modified.
Ote Binary Stdout Contract ✅ Passed Only dependency metadata changed (go.mod/go.sum/vendor/modules.txt); no process-level code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only dependency files changed; no new Ginkgo e2e tests or network-using test code were added.
No-Weak-Crypto ✅ Passed PR only updates module metadata to x/crypto v0.52.0; no weak algorithms, custom crypto, or insecure secret comparisons appear in changed code.
Container-Privileges ✅ Passed PR only changes Go module metadata (client/go.mod, go.sum, vendor/modules.txt); no container/K8s manifest settings like privileged or hostPID were introduced.
No-Sensitive-Data-In-Logs ✅ Passed Only dependency metadata changed; no application logging or sensitive-data handling was added in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2026
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shay23bra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.47%. Comparing base (607d578) to head (c5891ee).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10659      +/-   ##
==========================================
- Coverage   44.47%   44.47%   -0.01%     
==========================================
  Files         423      423              
  Lines       73327    73327              
==========================================
- Hits        32615    32614       -1     
  Misses      37802    37802              
- Partials     2910     2911       +1     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shay23bra

Copy link
Copy Markdown
Contributor Author

Closing as duplicate — the same golang.org/x/crypto bump is already covered by an existing PR on this branch.

@shay23bra shay23bra closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants