Skip to content

Don't call upstream if nothing found via friendly ID search #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corwinstephen wants to merge 4 commits into
base: master
Choose a base branch
from
+2 −2
Open

Don't call upstream if nothing found via friendly ID search #972

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1001e14
Don't call upstream if nothing found via friendly ID search
corwinstephen Jun 25, 2021
4fad564
Convert from guard clause
parndt Jul 19, 2021
ab4b437
Merge remote-tracking branch 'norman/master' into prevent-false-posit…
parndt Jul 19, 2021
4f1f77a
Merge remote-tracking branch 'norman/master' into prevent-false-posit…
parndt Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/friendly_id/finder_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def find(*args)
def exists?(conditions = :none)
return super if conditions.unfriendly_id?
return true if exists_by_friendly_id?(conditions)
Comment thread
parndt marked this conversation as resolved.
Outdated
super
false
Comment thread
parndt marked this conversation as resolved.
Outdated
end

# Finds exclusively by the friendly id, completely bypassing original
Expand Down