Don't call upstream if nothing found via friendly ID search#972
Open
corwinstephen wants to merge 4 commits into
Open
Don't call upstream if nothing found via friendly ID search#972corwinstephen wants to merge 4 commits into
corwinstephen wants to merge 4 commits into
Conversation
parndt
reviewed
Jun 29, 2021
parndt
reviewed
Jun 29, 2021
Collaborator
|
@corwinstephen thanks I added some suggestions; we can convert this from a guard clause to just use the result of |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Hey sorry to disappear on this. What are you thinking here? Looks like the specs had some trouble getting started. |
Collaborator
|
@corwinstephen it looks to me like there are 16 test failures and they're probably related to us expecting friendly_id to call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent false positives when friendly ID doesn't match