Switch from widening_mul to carrying_mul - #682
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the RISC-V interpreter to use carrying_mul instead of widening_mul to stay compatible with upcoming Rust upstream API changes.
Changes:
- Replaced
widening_mulcalls withcarrying_mul(..., 0)in RV32/RV64MULH-style paths and a related test. - Updated crate feature gates to remove
widening_muland addsigned_bigint_helpers.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/execution/ab-riscv-interpreter/src/rv64/m/tests.rs | Adjusts mulh test to use carrying_mul API. |
| crates/execution/ab-riscv-interpreter/src/rv64/m.rs | Swaps widening_mul for carrying_mul in signed×signed high-half multiply. |
| crates/execution/ab-riscv-interpreter/src/rv32/m.rs | Same API swap as RV64 for 32-bit path. |
| crates/execution/ab-riscv-interpreter/src/lib.rs | Updates nightly feature gate from widening_mul to signed_bigint_helpers. |
| crates/execution/ab-riscv-coremark-runner/src/main.rs | Updates feature gate list to remove widening_mul. |
| crates/execution/ab-riscv-act4-runner/src/main.rs | Updates feature gate list to remove widening_mul. |
| crates/contracts/core/ab-contract-file/src/lib.rs | Updates feature gate list to remove widening_mul. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nazar-pc
force-pushed
the
switch-to-carrying_mul
branch
from
May 21, 2026 22:53
22707a8 to
abecfb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for upstream API changes: rust-lang/rust#156644