Skip to content

Switch from widening_mul to carrying_mul - #682

Merged
nazar-pc merged 1 commit into
mainfrom
switch-to-carrying_mul
May 21, 2026
Merged

Switch from widening_mul to carrying_mul#682
nazar-pc merged 1 commit into
mainfrom
switch-to-carrying_mul

Conversation

@nazar-pc

Copy link
Copy Markdown
Owner

Prepare for upstream API changes: rust-lang/rust#156644

Copilot AI review requested due to automatic review settings May 21, 2026 22:44
@nazar-pc
nazar-pc enabled auto-merge May 21, 2026 22:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the RISC-V interpreter to use carrying_mul instead of widening_mul to stay compatible with upcoming Rust upstream API changes.

Changes:

  • Replaced widening_mul calls with carrying_mul(..., 0) in RV32/RV64 MULH-style paths and a related test.
  • Updated crate feature gates to remove widening_mul and add signed_bigint_helpers.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/execution/ab-riscv-interpreter/src/rv64/m/tests.rs Adjusts mulh test to use carrying_mul API.
crates/execution/ab-riscv-interpreter/src/rv64/m.rs Swaps widening_mul for carrying_mul in signed×signed high-half multiply.
crates/execution/ab-riscv-interpreter/src/rv32/m.rs Same API swap as RV64 for 32-bit path.
crates/execution/ab-riscv-interpreter/src/lib.rs Updates nightly feature gate from widening_mul to signed_bigint_helpers.
crates/execution/ab-riscv-coremark-runner/src/main.rs Updates feature gate list to remove widening_mul.
crates/execution/ab-riscv-act4-runner/src/main.rs Updates feature gate list to remove widening_mul.
crates/contracts/core/ab-contract-file/src/lib.rs Updates feature gate list to remove widening_mul.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/execution/ab-riscv-interpreter/src/rv64/m.rs Outdated
Comment thread crates/execution/ab-riscv-interpreter/src/rv32/m.rs Outdated
@nazar-pc
nazar-pc force-pushed the switch-to-carrying_mul branch from 22707a8 to abecfb4 Compare May 21, 2026 22:53
@nazar-pc
nazar-pc merged commit dd1bed0 into main May 21, 2026
65 checks passed
@nazar-pc
nazar-pc deleted the switch-to-carrying_mul branch May 21, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants