Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/ConnectionConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ function ConnectionConfig(options) {
}

if (this.ssl) {
this.ssl = cloneSsl(this.ssl);

// Default rejectUnauthorized to true
this.ssl.rejectUnauthorized = this.ssl.rejectUnauthorized !== false;
}
Expand All @@ -63,6 +65,20 @@ function ConnectionConfig(options) {
this.clientFlags = ConnectionConfig.mergeFlags(defaultFlags, options.flags);
}

function cloneSsl(ssl) {
if (typeof ssl !== 'object') {
return ssl;
}

var clone = {};

for (var key in ssl) {
clone[key] = ssl[key];
}

return clone;
}

ConnectionConfig.mergeFlags = function mergeFlags(defaultFlags, userFlags) {
var allFlags = ConnectionConfig.parseFlagList(defaultFlags);
var newFlags = ConnectionConfig.parseFlagList(userFlags);
Expand Down
26 changes: 26 additions & 0 deletions test/unit/test-ConnectionConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,17 @@ test('ConnectionConfig#Constructor.ssl', {
assert.equal(config.ssl, false);
},

'does not mutate ssl options object': function() {
var ssl = {};
var config = new ConnectionConfig({
ssl: ssl
});

assert.notEqual(config.ssl, ssl);
assert.deepEqual(ssl, {});
assert.equal(config.ssl.rejectUnauthorized, true);
},

'string "Amazon RDS" loads valid profile': function() {
var config = new ConnectionConfig({
ssl: 'Amazon RDS'
Expand All @@ -189,6 +200,21 @@ test('ConnectionConfig#Constructor.ssl', {
});
},

'string "Amazon RDS" does not mutate profile object': function() {
var SSLProfiles = require(common.lib + '/protocol/constants/ssl_profiles');
var profile = SSLProfiles['Amazon RDS'];

delete profile.rejectUnauthorized;

var config = new ConnectionConfig({
ssl: 'Amazon RDS'
});

assert.notEqual(config.ssl, profile);
assert.equal(profile.rejectUnauthorized, undefined);
assert.equal(config.ssl.rejectUnauthorized, true);
},

'throws on unknown profile name': function() {
var config;
var error;
Expand Down
Loading