fix: avoid mutating ssl connection options - #2586
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2380.
This copies SSL option objects before applying the default
rejectUnauthorizedvalue. The connection config still defaultsrejectUnauthorizedtotrue, but the caller-providedsslobject and shared SSL profile objects are left unchanged.Validation:
FILTER=unit/test-ConnectionConfig npm_config_cache=/tmp/mysql-2380-npm-cache npm testnpm_config_cache=/tmp/mysql-2380-npm-cache npm run lintmysql.createConnection({ ssl: {} })leaves the original config as{ "ssl": {} }whileconnection.config.ssl.rejectUnauthorizedistrueFILTER=unit npm testwas attempted on Node 24 and Node 18; existing SSL fake-server tests fail locally because modern OpenSSL rejects the repo test certs (ee key too smallon Node 24, expired certificate on Node 18), while the focused config tests pass.