Skip to content

Updating the log in the function '_on_reader_done' #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shizacat wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

Updating the log in the function '_on_reader_done' #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion aiormq/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import platform
import ssl
import sys
import traceback
from abc import abstractmethod, ABC
from base64 import b64decode
from collections.abc import AsyncIterable
Expand Down Expand Up @@ -626,7 +627,14 @@ def _on_reader_done(self, task: asyncio.Task) -> None:
log.debug("Reader exited for %r", self)

if not task.cancelled() and task.exception() is not None:
log.debug("Cancelling cause reader exited abnormally")
log.critical(

@mosquito mosquito Oct 20, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing critical in general case, when your program purpose is only doing amqp communication it is critical, yes. But in general case it is just warning. You can rename it yourself or I can merge it and little bit rewrite.

"Cancelling cause reader exited abnormally\n%s",
"".join(traceback.format_exception(
type(task.exception()),
task.exception(),
task.exception().__traceback__,
))
)
self.set_close_reason(
reply_code=500, reply_text="reader unexpected closed",
)
Expand Down
Loading