Updating the log in the function '_on_reader_done' - #213
Open
shizacat wants to merge 1 commit into
Open
Conversation
mosquito
reviewed
Oct 20, 2025
|
|
||
| if not task.cancelled() and task.exception() is not None: | ||
| log.debug("Cancelling cause reader exited abnormally") | ||
| log.critical( |
Owner
There was a problem hiding this comment.
Nothing critical in general case, when your program purpose is only doing amqp communication it is critical, yes. But in general case it is just warning. You can rename it yourself or I can merge it and little bit rewrite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an incorrect frame is sent to the '__reader', it will cause a silent error. Only in debug mode can we see the error message. However, we only see the message and not the reason for the error.
Of course, the ideal solution would be a concise description of the error and an indication of what is wrong with the frame, but for now, a traceback is the compromise.
Example:
send frame where set properties.timestamp=999999999999999