Skip to content

test(client-tree): enable one 8915 case #27647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jason-ha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(client-tree): enable one 8915 case #27647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/dds/tree/src/test/shared-tree/sharedTree.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2319,8 +2319,7 @@ describe("SharedTree", () => {
new TreeViewConfiguration({ schema: JsonAsTree.Array, enableSchemaValidation }),
);
view1Json.upgradeSchema();
// TODO:#8915: This should be able to insert the _number_ 44, not the string, but currently cannot - see bug #8915
view1Json.root.insertAtEnd("44");
view1Json.root.insertAtEnd(44);

tree1.containerRuntime.connected = true;

Expand Down Expand Up @@ -2467,10 +2466,14 @@ describe("SharedTree", () => {
const view = tree.viewWith(
new TreeViewConfiguration({ schema, enableSchemaValidation }),
);
view.initialize({ foo: [] });
Tree.runTransaction(view, () => {
view.initialize({ foo: [] });
view.root.foo.insertAtStart("a");
view.root.foo.insertAtStart("b");
// This dispose does not seem to be enough to prevent
// Error: Cannot create a second tree view from the same checkout
// when creating view2 below.
view.dispose();

// Update schema which now allows all primitives under field "foo".
const view2 = tree.viewWith(
Expand Down
Loading