Skip to content

test(build-infra): add gitignore utils#27616

Open
tylerbutler wants to merge 5 commits into
microsoft:mainfrom
tylerbutler:split/build-infra-gitignore-utils
Open

test(build-infra): add gitignore utils#27616
tylerbutler wants to merge 5 commits into
microsoft:mainfrom
tylerbutler:split/build-infra-gitignore-utils

Conversation

@tylerbutler

@tylerbutler tylerbutler commented Jun 29, 2026

Copy link
Copy Markdown
Member

Description

Adds build-infrastructure gitignore utilities backed by tinyglobby and the ignore package, with direct tests for the intended gitignore semantics.

The tests cover ancestor and descendant .gitignore files, negation patterns, relative-path filtering, ordering expectations, and explicit cache clearing for long-running processes.

Reviewer Guidance

The review process is outlined on this wiki page.

Please focus review on the helper API, gitignore semantics, and cache behavior. The workspaceCompat migration is split into a follow-up PR.

Copilot AI review requested due to automatic review settings June 29, 2026 18:46
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (439 lines, 4 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • build-tools/pnpm-lock.yaml: Generated file

@tylerbutler tylerbutler changed the title refactor(build-infra): add gitignore utils test(build-infra): add gitignore utils Jun 29, 2026
@tylerbutler tylerbutler force-pushed the split/build-infra-gitignore-utils branch from c5741a8 to c29f039 Compare June 29, 2026 19:02
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: 83f341cb4e76e4a7438a31a486fb317fb8a3e2e3
Head commit: f92b724c0ae973f69e73d5387b100fe6c81f4d49

Pending — Build - client packages is running. Results will appear here when the build completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants