refactor(build-infra): use gitignore utils#27617
Open
tylerbutler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the legacy workspace compatibility package discovery path from
globby.sync(..., { gitignore: true })totinyglobby.globSyncplus the gitignore utility introduced in the parent PR.This keeps the behavior change separate from the helper and test coverage, making the review surface limited to wiring the helper into
workspaceCompat.Reviewer Guidance
The review process is outlined on this wiki page.
Review this after #27616. This PR should contain only the
workspaceCompatmigration and any lockfile adjustment needed after removingglobbyfrom build-infrastructure.