Skip to content

compiler: correctly mark a run() result as compiled=False when the program fails #15881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcbaker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

compiler: correctly mark a run() result as compiled=False when the program fails #15881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mesonbuild/compilers/compilers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ def run(self, code: 'mesonlib.FileOrString',
mlog.debug(so)
mlog.debug('Program stderr:\n')
mlog.debug(se)
return RunResult(True, pe.returncode, so, se)
return RunResult(pe.returncode == 0, pe.returncode, so, se)

# Caching run() in general seems too risky (no way to know what the program
# depends on), but some callers know more about the programs they intend to
Expand Down
Loading