compiler: correctly mark a run() result as compiled=False when the program fails#15881
Open
dcbaker wants to merge 1 commit into
Open
compiler: correctly mark a run() result as compiled=False when the program fails#15881dcbaker wants to merge 1 commit into
compiled=False when the program fails#15881dcbaker wants to merge 1 commit into
Conversation
…program fails We correctly catch that the program failed to compile and mark it as "result failed" but we don't do the same if the program fails to actually run.
Contributor
|
I think this is a potential cause of regressions and needs release notes. |
bonzini
added
the
needs-relnotes
Member
Author
|
I'm gonna move this to 1.13, there's already a lot of big, deep changes in 1.12, and this seems like another potential cause of regressions and I'd rather wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We correctly catch that the program failed to compile and mark it as "result failed" but we don't do the same if the program fails to actually run.