feat: switch from FCM token to Firebase installation ID - #1911
Draft
boringcactus wants to merge 1 commit into
Draft
feat: switch from FCM token to Firebase installation ID#1911boringcactus wants to merge 1 commit into
boringcactus wants to merge 1 commit into
Conversation
boringcactus
force-pushed
the
mth-qsvmkpxoprzr
branch
from
July 31, 2026 20:05
930b183 to
1b9d626
Compare
KaylaBrady
approved these changes
Aug 3, 2026
|
|
||
| func application(_: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: Data) { | ||
| Messaging.messaging().apnsToken = deviceToken | ||
| Messaging.messaging().token { token, error in |
Collaborator
There was a problem hiding this comment.
question(non-blocking): What does the new code do here since it doesn't use the token? Is didRegisterForRemoteNotificationsWithDeviceToken hit if the device token isn't used anymore?
I am least familiar with how piece is set up, but it seems like the most obviously not 1-for-1 change, so figured I'd highlight it to learn more.
Member
Author
There was a problem hiding this comment.
The deviceToken here is the APNs token we get from iOS, and we still need to pass that to FCM so it can deliver messages correctly.
boringcactus
marked this pull request as draft
August 6, 2026 19:59
Member
Author
|
Things are busted; an eventual iOS bug fix should take care of things on iOS, but it’s not obvious what’s wrong on Android. |
boringcactus
force-pushed
the
mth-qsvmkpxoprzr
branch
from
August 11, 2026 14:59
1b9d626 to
356a397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Move from Firebase tokens to installation IDs
Swaps out the old FCM tokens for the new installation IDs everywhere. Pairs with mbta/mobile_app_backend#655.
iOS
[ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?[ ] Add temporary machine translations, marked "Needs Review"android
[ ] All user-facing strings added to strings resource in alphabetical order[ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Updated unit tests where needed. End-to-end delivery test still needs to be done.