mavlink_direct: fix setting target_component#2919
Merged
Merged
Conversation
MavlinkDirect and MavlinkDirectServer send_message() tried to set the libmav field "target_component_id" which doesn't exist (the MAVLink field is called "target_component"), so a target component set via MavlinkMessage::target_component_id was silently dropped and the message went out with target_component 0 (broadcast). Add regression tests covering both send directions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MavlinkDirect and MavlinkDirectServer
send_message()tried to set the libmav fieldtarget_component_id, which doesn't exist (the MAVLink field is calledtarget_component). A target component set viaMavlinkMessage::target_component_idwas therefore silently dropped and the message went out withtarget_component0 (broadcast).This fixes the field name in both plugins and adds regression system tests covering both send directions (verified to fail without the fix).