Add accessibility labels to service toggle buttons - #182
Open
Arsey wants to merge 1 commit into
Open
Conversation
VoiceOver announced each service's icon and name as two separate, unlabeled elements with no indication of on/off state. Add an accessibility label and value so each toggle reads as e.g. "Calendar, Enabled". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLDiNzrDds62dnD9NoCEJV
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VoiceOver reads each service row as an unlabeled icon button plus a separate text element, with no indication of on/off state. Screen-reader users can't tell which services are enabled, in an app whose main control surface is exactly these toggles.
This adds an accessibility label, value, and button trait to each toggle so it reads as e.g. "Calendar, Enabled".
Test plan
xcodebuild buildsucceeds