Make service rows fully interactive with hover and press feedback - #183
Open
Arsey wants to merge 3 commits into
Open
Make service rows fully interactive with hover and press feedback#183Arsey wants to merge 3 commits into
Arsey wants to merge 3 commits into
Conversation
VoiceOver announced each service's icon and name as two separate, unlabeled elements with no indication of on/off state. Add an accessibility label and value so each toggle reads as e.g. "Calendar, Enabled". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLDiNzrDds62dnD9NoCEJV
Only the small 26pt icon circle toggled a service; the label beside it was dead space. Make the whole row one button, add a hover highlight matching the menu's action rows, a pointing-hand cursor, a subtle press scale, and a dynamic Enable/Disable tooltip. Accessibility moves to the row so VoiceOver reads one element per service. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLDiNzrDds62dnD9NoCEJV
The colored icon communicated state but nothing communicated that the rows are clickable toggles. Add a mini switch at the trailing edge as an explicit affordance; it's display-only so the whole row remains the single click target. Rows return to their original 26pt height. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLDiNzrDds62dnD9NoCEJV
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only the 26pt icon circle toggles a service. The label next to it is dead space, and nothing signals that the rows are clickable at all: no hover state, no cursor change, no press feedback. First-time users don't discover that clicking a service toggles it.
This makes each row one control with the affordances users expect:
VoiceOver now sees one element per service instead of an unlabeled icon plus loose text.
Builds on #182; merging that first shrinks this diff to one commit.
Test plan
xcodebuild buildsucceeds