Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions packages/ra-ui-materialui/src/list/datatable/DataTable.spec.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import { fireEvent, render, screen, waitFor } from '@testing-library/react';
import { QueryClient } from '@tanstack/react-query';
import * as React from 'react';
import {
ResourceContextProvider,
TestMemoryRouter,
type AuthProvider,
} from 'ra-core';
import {
Basic,
Columns,
Expand All @@ -12,6 +18,8 @@ import {
StandaloneDynamic,
StandaloneStatic,
} from './DataTable.stories';
import { DataTable } from './DataTable';
import { AdminContext } from '../../AdminContext';

describe('DataTable', () => {
it('should render one row per record in the list', async () => {
Expand Down Expand Up @@ -218,6 +226,71 @@ describe('DataTable', () => {
});
});
describe('bulkActionButtons', () => {
it('should not enable delete permission queries without an auth provider', async () => {
const queryClient = new QueryClient();

render(
<TestMemoryRouter>
<AdminContext queryClient={queryClient}>
<ResourceContextProvider value="books">
<DataTable
bulkActionsToolbar={<></>}
data={[{ id: 1 }]}
isPending={false}
onSelect={jest.fn()}
onToggleItem={jest.fn()}
selectedIds={[]}
total={1}
>
<DataTable.Col source="id" />
</DataTable>
</ResourceContextProvider>
</AdminContext>
</TestMemoryRouter>
);

await waitFor(() => {
const [query] = queryClient.getQueryCache().findAll({
queryKey: ['auth', 'canAccess'],
});
expect(query.state.fetchStatus).toBe('idle');
expect(query.state.data).toBeUndefined();
});
});

it('should not check delete permissions when bulk actions are disabled', () => {
const authProvider: AuthProvider = {
canAccess: jest.fn().mockResolvedValue(true),
checkAuth: jest.fn().mockResolvedValue(undefined),
checkError: jest.fn().mockResolvedValue(undefined),
getPermissions: jest.fn().mockResolvedValue(undefined),
login: jest.fn().mockResolvedValue(undefined),
logout: jest.fn().mockResolvedValue(undefined),
};

render(
<TestMemoryRouter>
<AdminContext authProvider={authProvider}>
<ResourceContextProvider value="books">
<DataTable
bulkActionButtons={false}
data={[{ id: 1 }]}
isPending={false}
onSelect={jest.fn()}
onToggleItem={jest.fn()}
selectedIds={[]}
total={1}
>
<DataTable.Col source="id" />
</DataTable>
</ResourceContextProvider>
</AdminContext>
</TestMemoryRouter>
);

expect(authProvider.canAccess).not.toHaveBeenCalled();
});

it('should reveal bulk delete button by default on row selection', async () => {
render(<Basic />);
const checkboxes = await screen.findAllByRole('checkbox');
Expand Down
1 change: 1 addition & 0 deletions packages/ra-ui-materialui/src/list/datatable/DataTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ export const DataTable = React.forwardRef(function DataTable<
const { canAccess: canDelete } = useCanAccess({
resource: resourceFromContext,
action: 'delete',
...(props.bulkActionButtons === false ? { enabled: false } : {}),
});

const {
Expand Down
Loading