Skip to content

Fix error in the license_finder job in the merge queue#123

Merged
masutaka merged 2 commits into
mainfrom
dont-commit-license-report-in-merge-group
Dec 2, 2024
Merged

Fix error in the license_finder job in the merge queue#123
masutaka merged 2 commits into
mainfrom
dont-commit-license-report-in-merge-group

Conversation

@masutaka

@masutaka masutaka commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Summary

Fixed an error when trying to commit frontend/docs/packages-license.md in a merge queue job. No need for this commit in the merge queue.

https://github.com/liam-hq/liam/actions/runs/12112643630/job/33766381574

image

FYI: This error does not preclude merging PRs.

Related Issue

license_finder job was introduced by the following pull requests:

Changes

Do not commit frontend/docs/packages-license.md in merge queue jobs.

Testing

After this PR is aproved, I will temporarily run the merge queue job to make sure it is done.

Other Information

I will consider separately not to create commits 68e1fc5 that only update timestamp.

@masutaka masutaka self-assigned this Dec 2, 2024
@masutaka masutaka marked this pull request as ready for review December 2, 2024 07:13
@masutaka masutaka requested a review from a team as a code owner December 2, 2024 07:13
@masutaka masutaka requested review from FunamaYukina, MH4GF, hoshinotsuyoshi, junkisai and sasamuku and removed request for a team December 2, 2024 07:13

@MH4GF MH4GF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@masutaka masutaka added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 5104bf0 Dec 2, 2024
@masutaka masutaka deleted the dont-commit-license-report-in-merge-group branch December 2, 2024 07:20
@masutaka

masutaka commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

It works well!

https://github.com/liam-hq/liam/actions/runs/12114500484/job/33771150725

success

sasamuku added a commit that referenced this pull request Dec 16, 2024
- Removed the Share button from the AppBar component in ERDRenderer.
- Added a new CopyLinkButton component to the AppBar.
- The CopyLinkButton allows users to copy the current URL to the clipboard.

Closes #123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants