Skip to content

💄 style(command palette): fix column option indent indicator#3756

Merged
MH4GF merged 1 commit into
mainfrom
style/fix-column-option-indent-line
Oct 14, 2025
Merged

💄 style(command palette): fix column option indent indicator#3756
MH4GF merged 1 commit into
mainfrom
style/fix-column-option-indent-line

Conversation

@tnyo43

@tnyo43 tnyo43 commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

Issue

- resolve:

Why is this change needed?

In the previous version, each Column option have slight gaps in its indent line on top and bottom of it. This PR will remove the gap and connect the lines to make it prettier.

preview(Table input mode is activated): https://liam-erd-sample-a5vxtbr49-liambx.vercel.app

before after
Screenshot 0007-10-11 at 11 18 50 Screenshot 0007-10-11 at 11 25 48

Summary by CodeRabbit

  • Style
    • Refined the indentation guide in the command palette options to align from the top and span the full height of each item. This removes small vertical gaps, delivering a cleaner and more consistent appearance for nested entries. The update improves visual alignment and readability, especially when items vary in height or spacing, without altering functionality.

@giselles-ai

giselles-ai Bot commented Oct 11, 2025

Copy link
Copy Markdown

Finished running flow.

Step Status Updated(UTC)
1 Oct 11, 2025 2:25am
2 Oct 11, 2025 2:26am
3 Oct 11, 2025 2:26am

@vercel

vercel Bot commented Oct 11, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Oct 11, 2025 2:44am
liam-assets Ready Ready Preview Oct 11, 2025 2:44am
liam-erd-sample Ready Ready Preview Comment Oct 11, 2025 2:44am
liam-storybook Ready Ready Preview Comment Oct 11, 2025 2:44am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
liam-docs Ignored Ignored Preview Oct 11, 2025 2:44am

@supabase

supabase Bot commented Oct 11, 2025

Copy link
Copy Markdown

Updates to Preview Branch (style/fix-column-option-indent-line) ↗︎

Deployments Status Updated
Database Sat, 11 Oct 2025 02:38:28 UTC
Services Sat, 11 Oct 2025 02:38:28 UTC
APIs Sat, 11 Oct 2025 02:38:28 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Sat, 11 Oct 2025 02:38:28 UTC
Migrations Sat, 11 Oct 2025 02:38:31 UTC
Seeding Sat, 11 Oct 2025 02:38:31 UTC
Edge Functions Sat, 11 Oct 2025 02:38:31 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@coderabbitai

coderabbitai Bot commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Adjusts the vertical positioning of the indentation guide in the Command Palette options by modifying the .item.indent:before pseudo-element in a CSS module.

Changes

Cohort / File(s) Summary
CSS: Command Palette indentation line
frontend/packages/erd-core/src/features/erd/components/ERDRenderer/CommandPalette/CommandPaletteOptions/CommandPaletteOptions.module.css
Set .item.indent:before to top: 0 and height: 100% (from calc-based offsets) to align the 1px indentation line with the full item height.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

Review effort 2/5

Suggested reviewers

  • junkisai
  • MH4GF
  • NoritakaIkeda
  • sasamuku

Poem

I nudge a line from tip to toe,
A tidy trail where options go.
One pixel tall, it stands up straight—
From top to base, a perfect gate.
Tap-tap, I hop through CSS night,
A rabbit pleased with margins tight. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description follows the template by including both an Issue and a Why section, but the Issue section remains empty with only a struck-through placeholder instead of an actual reference, making it incomplete even though the change rationale and screenshots are well documented. Please populate the Issue section with the relevant issue identifier or remove that section if there is no issue to resolve, and eliminate the struck-through placeholder to fully conform to the repository’s description template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately describes the primary visual change, namely fixing the column option indent indicator in the command palette, and it directly reflects the CSS adjustment made in the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch style/fix-column-option-indent-line

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2745f7 and 33b9d7d.

📒 Files selected for processing (1)
  • frontend/packages/erd-core/src/features/erd/components/ERDRenderer/CommandPalette/CommandPaletteOptions/CommandPaletteOptions.module.css (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/packages/erd-core/src/features/erd/components/ERDRenderer/CommandPalette/CommandPaletteOptions/CommandPaletteOptions.module.css
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Supabase Preview
  • GitHub Check: frontend-ci
  • GitHub Check: frontend-lint
  • GitHub Check: Supabase Preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@giselles-ai

giselles-ai Bot commented Oct 11, 2025

Copy link
Copy Markdown

Check changeset necessity

Status:

  • REQUIRED

Reason:

  • Affects @liam-hq/erd-core, which is a target package covered by the Changeset policy.
  • User-facing change: fixes a visual bug in the Command Palette (indent indicator for column options).
  • No external API changes; this is a UI bug fix, which maps to a patch release in 0.x.
  • No valid changeset file detected in this PR.

Changeset (copy & paste):

---
"@liam-hq/erd-core": patch
---
- 🐛 Fix misaligned indent indicator in Command Palette column options
  - Adjust pseudo-element positioning and height in CommandPaletteOptions.module.css for correct vertical guideline rendering

@MH4GF MH4GF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@MH4GF MH4GF added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit ab783c2 Oct 14, 2025
30 checks passed
@MH4GF MH4GF deleted the style/fix-column-option-indent-line branch October 14, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants