-
Notifications
You must be signed in to change notification settings - Fork 392
Rails 8.0 Support, Postgres fixes #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JesseChavez
wants to merge
36
commits into
jruby:master
Choose a base branch
from
JesseChavez:rails_80_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
64021ef
Revert "Add Rails 8.1 compatibility"
brykgroup-andrews 49a13bc
Pin rdoc to ~> 7 to fix JRuby native compilation issues
brykgroup-andrews dab401b
Disable ReaperTest::test_reaper_works_after_pool_discard in JDBC due …
brykgroup-andrews b6a1bc3
Disable broken :test_url_invalid_adapter due to added sqlserver adapter
brykgroup-andrews a3a866f
Force numeric/boolean to be encoded as varchar to mirror behaviour of…
brykgroup-andrews 0131de7
Migrate client_min_messages in Postgres to use newer APIs
brykgroup-andrews c687b0c
Postgres now respects decode_dates setting
brykgroup-andrews 376e562
Fix Postgres disable_extension to work the same way enable_extenion w…
brykgroup-andrews dfd7620
Added fixednum lookup to Postgres columns for columnTypeMap to allow …
brykgroup-andrews 246a640
Monkey patch to allow time value parsing to fall through fallback_str…
brykgroup-andrews 84ca553
Fix postgres not returning a result object for raw queries
brykgroup-andrews dc722cc
Generalized timestamp infinity checking to support BigDecimal + other…
brykgroup-andrews 2b7118d
Update PostgreSQL::rename_enum to match rails implementation
brykgroup-andrews 7c62084
Update PostgreSQL::add_enum_value to match rails implementation
brykgroup-andrews 6a4a88f
Use ruby-side type casting in array params for correct range literal …
brykgroup-andrews 3a3e045
Fix dirty tracking when loading HStore from Postgres
brykgroup-andrews 0286957
Carry over set_constraints from rails Postgres driver
brykgroup-andrews 9929c0a
Match default PG gem stringtype connection param
brykgroup-andrews eb8975b
Implement raw_exec_query to fix AsyncHasManyAssociationsTest#test_asy…
brykgroup-andrews d4a6b20
Migrate query logging to match upstream ruby call style and signatures
brykgroup-andrews 974f9d4
Switch to base rails preprocess_query call, remove now-redundant :che…
brykgroup-andrews e9fe057
Properly handle returning: kwarg in exec_insert
brykgroup-andrews 84b926e
Properly handle raw SQL for upserts
brykgroup-andrews 58068df
Remove outdated and unneeded override of extract_table_ref_from_inser…
brykgroup-andrews 924b346
Remove outdated and unneeded override of default_sequence_name from P…
brykgroup-andrews 95d6cd6
Added default timezone to time/timestamp OID types
brykgroup-andrews 0eda888
Add JVM-compatible test_preserving_time_objects_with_local_time_conve…
brykgroup-andrews fda88d0
Exclude PessimisticLockingTest#test_with_lock_locks_with_no_args due …
brykgroup-andrews ccde2eb
Handle Rails 8.0 removed Numeric#toTime
brykgroup-andrews 5bfebe0
Exclude broken msgpack-jruby tests
brykgroup-andrews cb595b7
Insert json as type OTHER to allow for coersion to column type
brykgroup-andrews 1831186
Properly set timezone when setting timestamp params
brykgroup-andrews c672e9f
Disabled marshalling tests that are broken with AR format 6.1 + JRuby…
brykgroup-andrews 9accad2
Monkeypatch to work around bug in prism logger polyfill breaking tests
brykgroup-andrews 7e6d672
Synchronize ActiveSupport callback registration in tests to compensat…
brykgroup-andrews bbeafdc
Add support for PG bind-param hash in blob params
brykgroup-andrews File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
test/rails/excludes/postgresql/ActiveRecord/ConnectionAdapters/ReaperTest.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| exclude :test_some_time, 'intermittent failures, leaks thread, fires at high frequency' | ||
| exclude :test_connection_pool_starts_reaper, 'intermittent failures, leaks thread, fires at high frequency' | ||
| exclude :test_reaper_works_after_pool_discard, 'deadlocks under JDBC due to high frequency discard' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we know why this deadlocks? Of course we have lots of excludes but this seems like one we should try to fix rather than excluding. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be temporary; we need to work with rbs folks to get a release out with JRuby support.