Rails 8.0 Support, Postgres fixes - #1222

Open

JesseChavez wants to merge 36 commits into

jruby:masterfrom

JesseChavez:rails_80_fixes

JesseChavez commented Jul 20, 2026 •

edited

Loading

Contributor

Here is the work we have done, we are looking the failures of Postgres ARJDBC own tests failures.

We will also port the below changes that are in a old MR from us, we have that changes in production and they mean to be postgres fixes only but it seems they are sqlite and MySql

(bash)> git log -4
commit 8fca8db0990cd2f3fbf7a161b609aafdc2ed8f80 (HEAD -> 72-stable-prod-fixes, origin/72-stable-prod-fixes)
Author: Jesse Chavez <jesse.chavez.r@gmail.com>
Date:   Sat Dec 13 11:39:18 2025 +0900

    Fix queries like where(field: [""]) to match CRuby behaviour

commit aad30c3e4be23b0a63f533f56ae536d4e5f55ee2
Author: Jesse Chavez <jesse.chavez.r@gmail.com>
Date:   Fri Oct 17 22:40:46 2025 +0900

    Comment out code setting uuid type for plain varchar field

commit cf12d83fa383daa837f7e51dc5750dc840bfa1d3
Author: Jesse Chavez <jesse.chavez.r@gmail.com>
Date:   Sun Sep 28 12:50:37 2025 +0900

    Postgres, pass type casted binds for select queries

brykgroup-andrews added 30 commits

July 21, 2026 05:56


          Revert "Add Rails 8.1 compatibility"

64021ef

This reverts commit 2281241.

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Pin rdoc to ~> 7 to fix JRuby native compilation issues

49a13bc

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Disable ReaperTest::test_reaper_works_after_pool_discard in JDBC due …

dab401b

…to deadlocks

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Disable broken :test_url_invalid_adapter due to added sqlserver adapter

b6a1bc3

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Force numeric/boolean to be encoded as varchar to mirror behaviour of…

a3a866f

… PG gem

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Migrate client_min_messages in Postgres to use newer APIs

0131de7

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Postgres now respects decode_dates setting

c687b0c

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Fix Postgres disable_extension to work the same way enable_extenion w…

376e562

…orks

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Added fixednum lookup to Postgres columns for columnTypeMap to allow …

dfd7620

…for index-based lookup for BSON access

Mirrors upstream PG commit 100c86c00e

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Monkey patch to allow time value parsing to fall through fallback_str…

246a640

…ing_to_time

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Fix postgres not returning a result object for raw queries

84ca553

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Generalized timestamp infinity checking to support BigDecimal + other…

dc722cc

… numeric types

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Update PostgreSQL::rename_enum to match rails implementation

2b7118d

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Update PostgreSQL::add_enum_value to match rails implementation

7c62084

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Use ruby-side type casting in array params for correct range literal …

6a4a88f

…handling

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Fix dirty tracking when loading HStore from Postgres

3a3e045

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Carry over set_constraints from rails Postgres driver

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Match default PG gem stringtype connection param

9929c0a

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Implement raw_exec_query to fix AsyncHasManyAssociationsTest#test_asy…

eb8975b

…nc_load_has_many

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Migrate query logging to match upstream ruby call style and signatures

d4a6b20

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Switch to base rails preprocess_query call, remove now-redundant :che…

974f9d4

…ck_if_write_query and :mark_transaction_written_if_write

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Properly handle returning: kwarg in exec_insert

e9fe057

Now mirrors built-in exec_insert, so it returns more than just the PK

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Properly handle raw SQL for upserts

84b926e

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Remove outdated and unneeded override of extract_table_ref_from_inser…

58068df

…t_sql from Postgres adapter

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Remove outdated and unneeded override of default_sequence_name from P…

924b346

…ostgres adapter

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Added default timezone to time/timestamp OID types

95d6cd6

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Add JVM-compatible test_preserving_time_objects_with_local_time_conve…

0eda888

…rsion_to_default_timezone_utc

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Exclude PessimisticLockingTest#test_with_lock_locks_with_no_args due …

fda88d0

…to Arel bindings differing

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Handle Rails 8.0 removed Numeric#toTime

ccde2eb

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Exclude broken msgpack-jruby tests

5bfebe0

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>

brykgroup-andrews added 6 commits

July 21, 2026 05:56


          Insert json as type OTHER to allow for coersion to column type

cb595b7

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Properly set timezone when setting timestamp params

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Disabled marshalling tests that are broken with AR format 6.1 + JRuby…

c672e9f

… 10.0.5.0

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Monkeypatch to work around bug in prism logger polyfill breaking tests

9accad2

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Synchronize ActiveSupport callback registration in tests to compensat…

7e6d672

…e for a lack of a GIL

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>


          Add support for PG bind-param hash in blob params

bbeafdc

Signed-off-by: Jesse Chavez <jesse.chavez.r@gmail.com>

JesseChavez mentioned this pull request

miscellaneous 72 stable prod fixes (Postgres) #1206

Open

headius commented Aug 5, 2026

Member

Ok finally getting back to this. There's a lot here to review.

headius requested changes

View reviewed changes

headius left a comment

Member

Thankfully most of this is very small commits and they are largely reasonable. I have submitted some change request comments that should be addressed, especially any "hack" commits that admit they are poor solutions (let's iterate on those separately if they require more work).

As a general note, I'd like to avoid having to copy code from Rails every version, so any places where we are duplicating their code we should try to get them to move into a module. There's several such cases in this PR.

We could probably merge this and it would work great, but I'd like @JesseChavez to take a pass at addressing my comments and pull any especially hacky or inefficient commits out to separate PR(s).

src/java/arjdbc/postgresql/PostgreSQLRubyJdbcConnection.java


		private final CachingCallSite type_cast_site = new FunctionalCachingCallSite("type_cast");

		private Object[] typeCastArrayValues(final ThreadContext context, final IRubyObject adapter, final RubyArray<?> values) {

headius Aug 5, 2026

Member

This change concerns me; I'd like to see the equivalent code in the PG gem to be sure we're not doing excessive work here.

src/java/arjdbc/postgresql/PostgreSQLResult.java

-              import org.jruby.RubyModule;
-              import org.jruby.RubyNumeric;
-              import org.jruby.RubyString;
+              import org.jruby.*;

headius Aug 5, 2026

Member

Style concern: prefer explicit imports until there's at least ten of them.

src/java/arjdbc/jdbc/JdbcResult.java

                       processResultSet(context, resultSet);
                   }
+                  // HACK: Needed for postgres to be able to return a sane result type instead of just a RubyFixnum

headius Aug 5, 2026

Member

Need to figure out something better than a HACK for this. Note also concerns in the same commit about this not being the best impl. Let's figure out the best impl.

lib/arjdbc/abstract/time_value_jruby_compat_monkey_patch.rb

+              require "active_model/type/helpers/time_value"
+              # The caller only handles ArgumentError as a failure,
+              # but JRuby raises TypeError for invalid formats in Time.new() (non-standard),

headius Aug 5, 2026

Member

I'd like to have a JRuby bug reference here so we can revert this patch when JRuby gets fixed.

test/rails/excludes/mysql2/ActiveRecord/ConnectionAdapters/PoolConfig/ResolverTest.rb

		@@ -0,0 +1 @@
		exclude :test_url_invalid_adapter, "sqlserver is not a built-in adapter, so rails complains when validating the error"

headius Aug 5, 2026

Member

Very annoying that the Rails tests implicitly require there be no other adapters. This warrants a patch to Rails imho.

test/rails/excludes/postgresql/ActiveRecord/ConnectionAdapters/ReaperTest.rb

@@ @@ -1,2 +1,3 @@ @@
               exclude :test_some_time, 'intermittent failures, leaks thread, fires at high frequency'
               exclude :test_connection_pool_starts_reaper, 'intermittent failures, leaks thread, fires at high frequency'
+              exclude :test_reaper_works_after_pool_discard, 'deadlocks under JDBC due to high frequency discard'

headius Aug 5, 2026

Member

Do we know why this deadlocks? Of course we have lots of excludes but this seems like one we should try to fix rather than excluding.

Gemfile

                   gem 'minitest-rg', require: nil
                   gem 'minitest-rails', require: nil
                   gem 'benchmark-ips', require: nil
+                  gem 'rdoc', '~> 7', require: false

headius Aug 5, 2026

Member

This should be temporary; we need to work with rbs folks to get a release out with JRuby support.

headius commented Aug 5, 2026

Member

Also a general note: it's hard to evaluate this with all the 8.0 jobs failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet